From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 04/09] memcg: make zone_reclaim_stat
Date: Sun, 30 Nov 2008 11:06:43 -0500 [thread overview]
Message-ID: <4932BA13.7000409@redhat.com> (raw)
In-Reply-To: <20081130195731.8151.KOSAKI.MOTOHIRO@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> +struct zone_reclaim_stat*
> +mem_cgroup_get_reclaim_stat_by_page(struct page *page)
> +{
> + return NULL;
> +}
> + memcg_reclaim_stat = mem_cgroup_get_reclaim_stat_by_page(page);
> + memcg_reclaim_stat->recent_rotated[!!file]++;
> + memcg_reclaim_stat->recent_scanned[!!file]++;
Won't this cause a null pointer dereference when
not using memcg?
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 04/09] memcg: make zone_reclaim_stat
Date: Sun, 30 Nov 2008 11:06:43 -0500 [thread overview]
Message-ID: <4932BA13.7000409@redhat.com> (raw)
In-Reply-To: <20081130195731.8151.KOSAKI.MOTOHIRO@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> +struct zone_reclaim_stat*
> +mem_cgroup_get_reclaim_stat_by_page(struct page *page)
> +{
> + return NULL;
> +}
> + memcg_reclaim_stat = mem_cgroup_get_reclaim_stat_by_page(page);
> + memcg_reclaim_stat->recent_rotated[!!file]++;
> + memcg_reclaim_stat->recent_scanned[!!file]++;
Won't this cause a null pointer dereference when
not using memcg?
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-30 16:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-30 10:54 [PATCH 00/09] memcg: split-lru feature for memcg KOSAKI Motohiro
2008-11-30 10:54 ` KOSAKI Motohiro
2008-11-30 10:55 ` [PATCH 01/09] inactive_anon_is_low() move to vmscan.c KOSAKI Motohiro
2008-11-30 10:55 ` KOSAKI Motohiro
2008-11-30 15:18 ` Rik van Riel
2008-11-30 15:18 ` Rik van Riel
2008-11-30 10:56 ` [PATCH 02/09] memcg: make inactive_anon_is_low() KOSAKI Motohiro
2008-11-30 10:56 ` KOSAKI Motohiro
2008-11-30 12:25 ` Cyrill Gorcunov
2008-11-30 12:25 ` Cyrill Gorcunov
2008-11-30 14:00 ` KOSAKI Motohiro
2008-11-30 14:00 ` KOSAKI Motohiro
2008-11-30 12:50 ` Pekka Enberg
2008-11-30 12:50 ` Pekka Enberg
2008-11-30 14:04 ` KOSAKI Motohiro
2008-11-30 14:04 ` KOSAKI Motohiro
2008-11-30 15:24 ` Rik van Riel
2008-11-30 15:24 ` Rik van Riel
2008-11-30 10:57 ` [PATCH 03/09] introduce zone_reclaim struct KOSAKI Motohiro
2008-11-30 10:57 ` KOSAKI Motohiro
2008-11-30 15:27 ` Rik van Riel
2008-11-30 15:27 ` Rik van Riel
2008-11-30 10:59 ` [PATCH 04/09] memcg: make zone_reclaim_stat KOSAKI Motohiro
2008-11-30 10:59 ` KOSAKI Motohiro
2008-11-30 16:06 ` Rik van Riel [this message]
2008-11-30 16:06 ` Rik van Riel
2008-12-01 0:48 ` KOSAKI Motohiro
2008-12-01 0:48 ` KOSAKI Motohiro
2008-11-30 16:08 ` Rik van Riel
2008-11-30 16:08 ` Rik van Riel
2008-12-01 0:50 ` KOSAKI Motohiro
2008-12-01 0:50 ` KOSAKI Motohiro
2008-11-30 10:59 ` [PATCH 05/09] make zone_nr_pages() helper function KOSAKI Motohiro
2008-11-30 10:59 ` KOSAKI Motohiro
2008-11-30 16:10 ` Rik van Riel
2008-11-30 16:10 ` Rik van Riel
2008-11-30 11:00 ` [PATCH 06/09] make get_scan_ratio() to memcg awareness KOSAKI Motohiro
2008-11-30 11:00 ` KOSAKI Motohiro
2008-11-30 11:01 ` [PATCH 07/09] memcg: remove mem_cgroup_calc_reclaim() KOSAKI Motohiro
2008-11-30 11:01 ` KOSAKI Motohiro
2008-11-30 11:02 ` [PATCH 08/09] memcg: show inactive_ratio KOSAKI Motohiro
2008-11-30 11:02 ` KOSAKI Motohiro
2008-11-30 11:03 ` [PATCH 09/09] memcg: show reclaim stat KOSAKI Motohiro
2008-11-30 11:03 ` KOSAKI Motohiro
2008-12-01 2:00 ` [PATCH 00/09] memcg: split-lru feature for memcg KAMEZAWA Hiroyuki
2008-12-01 2:00 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4932BA13.7000409@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.