From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 04/11] make get_scan_ratio() to memcg safe
Date: Mon, 01 Dec 2008 09:50:09 -0500 [thread overview]
Message-ID: <4933F9A1.6080106@redhat.com> (raw)
In-Reply-To: <20081201211342.1CD6.KOSAKI.MOTOHIRO@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> Currently, get_scan_ratio() always calculate the balancing value for global reclaim and
> memcg reclaim doesn't use it.
> Therefore it doesn't have scan_global_lru() condition.
>
> However, we plan to expand get_scan_ratio() to be usable for memcg too, latter.
> Then, The dependency code of global reclaim in the get_scan_ratio() insert into
> scan_global_lru() condision explictly.
>
>
> this patch doesn't have any functional change.
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Good in principle, though of course this particular corner
case is not going to change when reclaiming a memcg :)
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 04/11] make get_scan_ratio() to memcg safe
Date: Mon, 01 Dec 2008 09:50:09 -0500 [thread overview]
Message-ID: <4933F9A1.6080106@redhat.com> (raw)
In-Reply-To: <20081201211342.1CD6.KOSAKI.MOTOHIRO@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> Currently, get_scan_ratio() always calculate the balancing value for global reclaim and
> memcg reclaim doesn't use it.
> Therefore it doesn't have scan_global_lru() condition.
>
> However, we plan to expand get_scan_ratio() to be usable for memcg too, latter.
> Then, The dependency code of global reclaim in the get_scan_ratio() insert into
> scan_global_lru() condision explictly.
>
>
> this patch doesn't have any functional change.
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Good in principle, though of course this particular corner
case is not going to change when reclaiming a memcg :)
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-12-01 14:50 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 12:10 [PATCH 00/11] memcg: split-lru feature for memcg take2 KOSAKI Motohiro
2008-12-01 12:10 ` KOSAKI Motohiro
2008-12-01 12:11 ` [PATCH 01/11] inactive_anon_is_low() move to vmscan.c KOSAKI Motohiro
2008-12-01 12:11 ` KOSAKI Motohiro
2008-12-01 12:12 ` [PATCH 02/11] introduce zone_reclaim struct KOSAKI Motohiro
2008-12-01 12:12 ` KOSAKI Motohiro
2008-12-01 12:13 ` [PATCH 03/11] make zone_nr_pages() helper function KOSAKI Motohiro
2008-12-01 12:13 ` KOSAKI Motohiro
2008-12-01 12:14 ` [PATCH 04/11] make get_scan_ratio() to memcg safe KOSAKI Motohiro
2008-12-01 12:14 ` KOSAKI Motohiro
2008-12-01 14:50 ` Rik van Riel [this message]
2008-12-01 14:50 ` Rik van Riel
2008-12-01 12:14 ` [PATCH 05/11] memcg: add null check to page_cgroup_zoneinfo() KOSAKI Motohiro
2008-12-01 12:14 ` KOSAKI Motohiro
2008-12-01 14:52 ` Rik van Riel
2008-12-01 14:52 ` Rik van Riel
2008-12-01 12:15 ` [PATCH 06/11] memcg: make inactive_anon_is_low() KOSAKI Motohiro
2008-12-01 12:15 ` KOSAKI Motohiro
2008-12-03 13:52 ` Balbir Singh
2008-12-03 13:52 ` Balbir Singh
2008-12-04 6:14 ` KOSAKI Motohiro
2008-12-04 6:14 ` KOSAKI Motohiro
2008-12-01 12:16 ` [PATCH 07/11] memcg: make mem_cgroup_zone_nr_pages() KOSAKI Motohiro
2008-12-01 12:16 ` KOSAKI Motohiro
2008-12-01 16:31 ` Rik van Riel
2008-12-01 16:31 ` Rik van Riel
2008-12-03 13:58 ` Balbir Singh
2008-12-03 13:58 ` Balbir Singh
2008-12-01 12:17 ` [PATCH 08/11] memcg: make zone_reclaim_stat KOSAKI Motohiro
2008-12-01 12:17 ` KOSAKI Motohiro
2008-12-01 16:33 ` Rik van Riel
2008-12-01 16:33 ` Rik van Riel
2008-12-03 14:06 ` Balbir Singh
2008-12-03 14:06 ` Balbir Singh
2008-12-04 7:15 ` KOSAKI Motohiro
2008-12-04 7:15 ` KOSAKI Motohiro
2008-12-01 12:18 ` [PATCH 09/11] memcg: remove mem_cgroup_calc_reclaim() KOSAKI Motohiro
2008-12-01 12:18 ` KOSAKI Motohiro
2008-12-01 17:09 ` Rik van Riel
2008-12-01 17:09 ` Rik van Riel
2008-12-01 12:19 ` [PATCH 10/11] memcg: show inactive_ratio KOSAKI Motohiro
2008-12-01 12:19 ` KOSAKI Motohiro
2008-12-01 17:10 ` Rik van Riel
2008-12-01 17:10 ` Rik van Riel
2008-12-02 9:05 ` KAMEZAWA Hiroyuki
2008-12-02 9:05 ` KAMEZAWA Hiroyuki
2008-12-01 12:19 ` [PATCH 11/11] memcg: show reclaim_stat KOSAKI Motohiro
2008-12-01 12:19 ` KOSAKI Motohiro
2008-12-01 17:11 ` Rik van Riel
2008-12-01 17:11 ` Rik van Riel
2008-12-02 9:05 ` KAMEZAWA Hiroyuki
2008-12-02 9:05 ` KAMEZAWA Hiroyuki
2008-12-03 14:19 ` Balbir Singh
2008-12-03 14:19 ` Balbir Singh
2008-12-03 16:15 ` KAMEZAWA Hiroyuki
2008-12-03 16:15 ` KAMEZAWA Hiroyuki
2008-12-02 4:25 ` [PATCH 00/11] memcg: split-lru feature for memcg take2 KAMEZAWA Hiroyuki
2008-12-02 4:25 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4933F9A1.6080106@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.