[PATCH] --build-id= none in newer ld versions PowerPC

[PATCH] --build-id= none in newer ld versions PowerPC

[Manoel Rebelo Abranches]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

This patch add --build-id=none option to newer ld versions when linking
kernel.elf.
This prevents grub-mkelfimage to behave wrongly.

-- 
Best Regards,

Manoel Abranches <mrabran@linux.vnet.ibm.com>
IBM Linux Technology Center Brazil

[-- Attachment #2: build_id_ld.patch --]
[-- Type: text/x-patch, Size: 2265 bytes --]

Index: aclocal.m4
===================================================================
--- aclocal.m4	(revision 1933)
+++ aclocal.m4	(working copy)
@@ -113,6 +113,7 @@
 
 if test "x$grub_cv_prog_ld_build_id_none" = xyes; then
   MODULE_LDFLAGS="$MODULE_LDFLAGS -Wl,--build-id=none"
+  PPC_BUILD_ID_FLAG="-Wl,--build-id=none"
 fi
 ])
 
Index: conf/powerpc-ieee1275.rmk
===================================================================
--- conf/powerpc-ieee1275.rmk	(revision 1933)
+++ conf/powerpc-ieee1275.rmk	(working copy)
@@ -87,7 +87,7 @@
 kernel_elf_CFLAGS = $(COMMON_CFLAGS)
 kernel_elf_ASFLAGS = $(COMMON_ASFLAGS)
 kernel_elf_LDFLAGS = $(COMMON_LDFLAGS) -static-libgcc -lgcc \
-	-Wl,-N,-S,-Ttext,0x200000,-Bstatic
+	-Wl,-N,-S,-Ttext,0x200000,-Bstatic $(PPC_BUILD_ID_FLAG)
 
 # Scripts.
 sbin_SCRIPTS = grub-install
Index: configure.ac
===================================================================
--- configure.ac	(revision 1933)
+++ configure.ac	(working copy)
@@ -330,6 +330,7 @@
 AC_SUBST(TARGET_CPPFLAGS)
 AC_SUBST(TARGET_LDFLAGS)
 AC_SUBST(MODULE_LDFLAGS)
+AC_SUBST(PPC_BUILD_ID_FLAG)
 
 # Set them to their new values for the tests below.
 CC="$TARGET_CC"
Index: Makefile.in
===================================================================
--- Makefile.in	(revision 1933)
+++ Makefile.in	(working copy)
@@ -73,6 +73,7 @@
 TARGET_IMG_LDFLAGS = @TARGET_IMG_LDFLAGS@
 TARGET_OBJ2ELF = @TARGET_OBJ2ELF@
 MODULE_LDFLAGS = @MODULE_LDFLAGS@
+PPC_BUILD_ID_FLAG = @PPC_BUILD_ID_FLAG@
 EXEEXT = @EXEEXT@
 OBJCOPY = @OBJCOPY@
 STRIP = @STRIP@
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 1933)
+++ ChangeLog	(working copy)
@@ -1,3 +1,14 @@
+2008-12-01  Manoel R. Abranches <mrabran@linux.vnet.ibm.com>
+
+	Add option --build-id=none to ld when linking kernel.elf in powerpc
+	to prevent creating additional LOAD segments.
+	Patch made with help from Paulo R. Pinatti <paulo@linux.vnet.ibm.com>.
+	* aclocal.m4: add --build-id=none to new variable when acceptable by
+	ld.
+	* conf/powerpc-ieee1275.rmk: New variable.
+	* configure.ac: New variable. 
+	* Makefile.in: New variable.
+
 2008-11-29  Robert Millan  <rmh@aybabtu.com>
 
 	* disk/ata.c (grub_ata_pciinit): Handle errors rised by

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Vesa Jääskeläinen]

Manoel Rebelo Abranches wrote:
> This patch add --build-id=none option to newer ld versions when linking
> kernel.elf.
> This prevents grub-mkelfimage to behave wrongly.


>  if test "x$grub_cv_prog_ld_build_id_none" = xyes; then
>    MODULE_LDFLAGS="$MODULE_LDFLAGS -Wl,--build-id=none"
> +  PPC_BUILD_ID_FLAG="-Wl,--build-id=none"
>  fi
>  ])

How about changing that to KERNEL_LDFLAGS? Then one could use it for
other purposes if needed?

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Manoel Rebelo Abranches]

On Mon, 2008-12-01 at 19:01 +0200, Vesa Jääskeläinen wrote:
> Manoel Rebelo Abranches wrote:
> > This patch add --build-id=none option to newer ld versions when linking
> > kernel.elf.
> > This prevents grub-mkelfimage to behave wrongly.
> 
> 
> >  if test "x$grub_cv_prog_ld_build_id_none" = xyes; then
> >    MODULE_LDFLAGS="$MODULE_LDFLAGS -Wl,--build-id=none"
> > +  PPC_BUILD_ID_FLAG="-Wl,--build-id=none"
> >  fi
> >  ])
> 
> How about changing that to KERNEL_LDFLAGS? Then one could use it for
> other purposes if needed?
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


There is already kernel_elf_LDFLAGS but its used for other architectures
too.
-- 
Best Regards,

Manoel Abranches <mrabran@linux.vnet.ibm.com>
IBM Linux Technology Center Brazil

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Vesa Jääskeläinen]

Manoel Rebelo Abranches wrote:
> On Mon, 2008-12-01 at 19:01 +0200, Vesa Jääskeläinen wrote:
>> Manoel Rebelo Abranches wrote:
>>> This patch add --build-id=none option to newer ld versions when linking
>>> kernel.elf.
>>> This prevents grub-mkelfimage to behave wrongly.
>>
>>>  if test "x$grub_cv_prog_ld_build_id_none" = xyes; then
>>>    MODULE_LDFLAGS="$MODULE_LDFLAGS -Wl,--build-id=none"
>>> +  PPC_BUILD_ID_FLAG="-Wl,--build-id=none"
>>>  fi
>>>  ])
>> How about changing that to KERNEL_LDFLAGS? Then one could use it for
>> other purposes if needed?
> 
> There is already kernel_elf_LDFLAGS but its used for other architectures
> too.

No no. I mean just KERNEL_LDFLAGS like comparison to MODULE_LDFLAGS. No
elf or nothing like that. Is there any problem if one provides this
setting even on x86 if linker recognizes it? (what is being tested
here). PPC_BUILD_ID_FLAG just sounds too specific.

Isn't EFI also using ELF? I assume this would be beneficial also there.

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Pavel Roskin]

On Tue, 2008-12-02 at 19:14 +0200, Vesa Jääskeläinen wrote:

> No no. I mean just KERNEL_LDFLAGS like comparison to MODULE_LDFLAGS. No
> elf or nothing like that. Is there any problem if one provides this
> setting even on x86 if linker recognizes it? (what is being tested
> here). PPC_BUILD_ID_FLAG just sounds too specific.
> 
> Isn't EFI also using ELF? I assume this would be beneficial also there.

I agree, we should not be be multiplying hacks.  There is already code
adding -Wl,--build-id=none to TARGET_LDFLAGS.  It's a macro
grub_PROG_LD_BUILD_ID_NONE in aclocal.m4.  What's wrong with it?  Does
it fail to add -Wl,--build-id=none on PowerPC or is TARGET_LDFLAGS not
used to link kernel.elf?

What are the symptoms caused by not using -Wl,--build-id=none?

-- 
Regards,
Pavel Roskin

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Manoel Rebelo Abranches]

The variable TARGET_LDFLAGS. isnt set but MODULE_LDFLAGS is instead.

  if test "x$grub_cv_prog_ld_build_id_none" = xyes; then
     MODULE_LDFLAGS="$MODULE_LDFLAGS -Wl,--build-id=none"

I could change to use TARGET_LDFLAGS if it wont brake other
architectures.
We were using PPC_BUILD_ID_FLAG because it was intended to be only to
PowerPC at first. I can tell if it is needed for others architectures
and if it wont brake others as well.

On Tue, 2008-12-02 at 13:34 -0500, Pavel Roskin wrote:
> On Tue, 2008-12-02 at 19:14 +0200, Vesa Jääskeläinen wrote:
> 
> > No no. I mean just KERNEL_LDFLAGS like comparison to MODULE_LDFLAGS. No
> > elf or nothing like that. Is there any problem if one provides this
> > setting even on x86 if linker recognizes it? (what is being tested
> > here). PPC_BUILD_ID_FLAG just sounds too specific.
> > 
> > Isn't EFI also using ELF? I assume this would be beneficial also there.
> 
> I agree, we should not be be multiplying hacks.  There is already code
> adding -Wl,--build-id=none to TARGET_LDFLAGS.  It's a macro
> grub_PROG_LD_BUILD_ID_NONE in aclocal.m4.  What's wrong with it?  Does
> it fail to add -Wl,--build-id=none on PowerPC or is TARGET_LDFLAGS not
> used to link kernel.elf?
> 
> What are the symptoms caused by not using -Wl,--build-id=none?
> 
-- 
Best Regards,

Manoel Abranches <mrabran@linux.vnet.ibm.com>
IBM Linux Technology Center Brazil

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Manoel Rebelo Abranches]

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

Hi made a patch to add --build-id=none to TARGET_LDFLAGS instead of
MODULE_LDFLAGS. with this it is passed to ld when linking kernel.elf.

without this kernel.elf creates a additional LOAD segment with a virtual
address in PhysAddr witch causes problem with OF and causes
grub-mkelfimage to not work correctly.

On Tue, 2008-12-02 at 13:34 -0500, Pavel Roskin wrote:
> On Tue, 2008-12-02 at 19:14 +0200, Vesa Jääskeläinen wrote:
> 
> > No no. I mean just KERNEL_LDFLAGS like comparison to MODULE_LDFLAGS. No
> > elf or nothing like that. Is there any problem if one provides this
> > setting even on x86 if linker recognizes it? (what is being tested
> > here). PPC_BUILD_ID_FLAG just sounds too specific.
> > 
> > Isn't EFI also using ELF? I assume this would be beneficial also there.
> 
> I agree, we should not be be multiplying hacks.  There is already code
> adding -Wl,--build-id=none to TARGET_LDFLAGS.  It's a macro
> grub_PROG_LD_BUILD_ID_NONE in aclocal.m4.  What's wrong with it?  Does
> it fail to add -Wl,--build-id=none on PowerPC or is TARGET_LDFLAGS not
> used to link kernel.elf?
> 
> What are the symptoms caused by not using -Wl,--build-id=none?
> 
-- 
Best Regards,

Manoel Abranches <mrabran@linux.vnet.ibm.com>
IBM Linux Technology Center Brazil

[-- Attachment #2: build_id.patch --]
[-- Type: text/x-patch, Size: 938 bytes --]

Index: aclocal.m4
===================================================================
--- aclocal.m4	(revision 1933)
+++ aclocal.m4	(working copy)
@@ -112,7 +112,7 @@
 AC_MSG_RESULT([$grub_cv_prog_ld_build_id_none])
 
 if test "x$grub_cv_prog_ld_build_id_none" = xyes; then
-  MODULE_LDFLAGS="$MODULE_LDFLAGS -Wl,--build-id=none"
+  TARGET_LDFLAGS="$TARGET_LDFLAGS -Wl,--build-id=none"
 fi
 ])
 
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 1933)
+++ ChangeLog	(working copy)
@@ -1,3 +1,10 @@
+2008-12-04  Manoel R. Abranches <mrabran@linux.vnet.ibm.com>
+		
+	Add --build-id=none to all ld calls instead of only the ones related
+	to modules. This correct a problem with grub-mkelfimage.
+	* aclocal.m4: Move --build-id=none from MODULE_LDFLAGS to
+	TARGET_LDFLAGS
+
 2008-11-29  Robert Millan  <rmh@aybabtu.com>
 
 	* disk/ata.c (grub_ata_pciinit): Handle errors rised by

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Manoel Rebelo Abranches]

There are any objections for this patch? Without this grub wont work in
PowerPC when using newer ld version.
thanks

On Thu, 2008-12-04 at 12:08 -0200, Manoel Rebelo Abranches wrote:
> Hi made a patch to add --build-id=none to TARGET_LDFLAGS instead of
> MODULE_LDFLAGS. with this it is passed to ld when linking kernel.elf.
> 
> without this kernel.elf creates a additional LOAD segment with a virtual
> address in PhysAddr witch causes problem with OF and causes
> grub-mkelfimage to not work correctly.
> 
> On Tue, 2008-12-02 at 13:34 -0500, Pavel Roskin wrote:
> > On Tue, 2008-12-02 at 19:14 +0200, Vesa Jääskeläinen wrote:
> > 
> > > No no. I mean just KERNEL_LDFLAGS like comparison to MODULE_LDFLAGS. No
> > > elf or nothing like that. Is there any problem if one provides this
> > > setting even on x86 if linker recognizes it? (what is being tested
> > > here). PPC_BUILD_ID_FLAG just sounds too specific.
> > > 
> > > Isn't EFI also using ELF? I assume this would be beneficial also there.
> > 
> > I agree, we should not be be multiplying hacks.  There is already code
> > adding -Wl,--build-id=none to TARGET_LDFLAGS.  It's a macro
> > grub_PROG_LD_BUILD_ID_NONE in aclocal.m4.  What's wrong with it?  Does
> > it fail to add -Wl,--build-id=none on PowerPC or is TARGET_LDFLAGS not
> > used to link kernel.elf?
> > 
> > What are the symptoms caused by not using -Wl,--build-id=none?
> > 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
-- 
Best Regards,

Manoel Abranches <mrabran@linux.vnet.ibm.com>
IBM Linux Technology Center Brazil

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Jerone Young]

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

Did anyone have any objections to this patch. Not sure if anyone had any
craving to use --build-id. If not I'll check it in in the next week.

                                                          Jerone

On Thu, Dec 4, 2008 at 8:08 AM, Manoel Rebelo Abranches <
mrabran@linux.vnet.ibm.com> wrote:

> Hi made a patch to add --build-id=none to TARGET_LDFLAGS instead of
> MODULE_LDFLAGS. with this it is passed to ld when linking kernel.elf.
>
> without this kernel.elf creates a additional LOAD segment with a virtual
> address in PhysAddr witch causes problem with OF and causes
> grub-mkelfimage to not work correctly.
>
> On Tue, 2008-12-02 at 13:34 -0500, Pavel Roskin wrote:
> > On Tue, 2008-12-02 at 19:14 +0200, Vesa Jääskeläinen wrote:
> >
> > > No no. I mean just KERNEL_LDFLAGS like comparison to MODULE_LDFLAGS. No
> > > elf or nothing like that. Is there any problem if one provides this
> > > setting even on x86 if linker recognizes it? (what is being tested
> > > here). PPC_BUILD_ID_FLAG just sounds too specific.
> > >
> > > Isn't EFI also using ELF? I assume this would be beneficial also there.
> >
> > I agree, we should not be be multiplying hacks.  There is already code
> > adding -Wl,--build-id=none to TARGET_LDFLAGS.  It's a macro
> > grub_PROG_LD_BUILD_ID_NONE in aclocal.m4.  What's wrong with it?  Does
> > it fail to add -Wl,--build-id=none on PowerPC or is TARGET_LDFLAGS not
> > used to link kernel.elf?
> >
> > What are the symptoms caused by not using -Wl,--build-id=none?
> >
> --
> Best Regards,
>
> Manoel Abranches <mrabran@linux.vnet.ibm.com>
> IBM Linux Technology Center Brazil
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>

[-- Attachment #2: Type: text/html, Size: 2820 bytes --]

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Pavel Roskin]

Quoting Jerone Young <jerone@gmail.com>:

> Did anyone have any objections to this patch. Not sure if anyone had any
> craving to use --build-id. If not I'll check it in in the next week.

Where is the current version of the patch?  Can we have a look first?

-- 
Regards,
Pavel Roskin

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Jerone Young]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

http://lists.gnu.org/archive/html/grub-devel/2008-12/msg00024.html

It is the attachment.

On Mon, Jan 5, 2009 at 12:53 AM, Pavel Roskin <proski@gnu.org> wrote:

> Quoting Jerone Young <jerone@gmail.com>:
>
>  Did anyone have any objections to this patch. Not sure if anyone had any
>> craving to use --build-id. If not I'll check it in in the next week.
>>
>
> Where is the current version of the patch?  Can we have a look first?
>
> --
> Regards,
> Pavel Roskin
>

[-- Attachment #2: Type: text/html, Size: 1092 bytes --]

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Robert Millan]

On Mon, Jan 05, 2009 at 01:09:50AM -0600, Jerone Young wrote:
> http://lists.gnu.org/archive/html/grub-devel/2008-12/msg00024.html
> 
> It is the attachment.
> 
> On Mon, Jan 5, 2009 at 12:53 AM, Pavel Roskin <proski@gnu.org> wrote:
> 
> > Quoting Jerone Young <jerone@gmail.com>:
> >
> >  Did anyone have any objections to this patch. Not sure if anyone had any
> >> craving to use --build-id. If not I'll check it in in the next week.
> >>
> >
> > Where is the current version of the patch?  Can we have a look first?
> >
> > --
> > Regards,
> > Pavel Roskin

It seems nobody objected...

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

RE: [PATCH] --build-id= none in newer ld versions PowerPC

[Gregg C Levine]

Hello!
Folks I gave up objecting on things discussed here, and then ending up in a
patch, about three days into the whole discussion that eventually created
code in SVN for GRUB2.

Therefore if anything does come up and you, Robert, feel I should comment,
please say so.

I do have one thing to complain about, the use of signed e-mail on a public
list that can be searched via Google. Regardless of how the credentials are
created, they could be found and copied and worse used against the person
who created.
--
Gregg C Levine hansolofalcon@worldnet.att.net
"The Force will be with you always." Obi-Wan Kenobi
  


> -----Original Message-----
> From: grub-devel-bounces+hansolofalcon=worldnet.att.net@gnu.org
[mailto:grub-devel-
> bounces+hansolofalcon=worldnet.att.net@gnu.org] On Behalf Of Robert Millan
> Sent: Saturday, February 07, 2009 2:51 PM
> To: The development of GRUB 2
> Cc: Pavel Roskin; Jerone Young
> Subject: Re: [PATCH] --build-id= none in newer ld versions PowerPC
> 
> On Mon, Jan 05, 2009 at 01:09:50AM -0600, Jerone Young wrote:
> > http://lists.gnu.org/archive/html/grub-devel/2008-12/msg00024.html
> >
> > It is the attachment.
> >
> > On Mon, Jan 5, 2009 at 12:53 AM, Pavel Roskin <proski@gnu.org> wrote:
> >
> > > Quoting Jerone Young <jerone@gmail.com>:
> > >
> > >  Did anyone have any objections to this patch. Not sure if anyone had
any
> > >> craving to use --build-id. If not I'll check it in in the next week.
> > >>
> > >
> > > Where is the current version of the patch?  Can we have a look first?
> > >
> > > --
> > > Regards,
> > > Pavel Roskin
> 
> It seems nobody objected...
> 
> --
> Robert Millan

Re: [PATCH] --build-id= none in newer ld versions PowerPC

[Pavel Roskin]

On Mon, 2009-01-05 at 01:09 -0600, Jerone Young wrote:
> http://lists.gnu.org/archive/html/grub-devel/2008-12/msg00024.html
> 
> It is the attachment.

Applied.

-- 
Regards,
Pavel Roskin