From: "Steven A. Falco" <sfalco@harris.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors
Date: Tue, 02 Dec 2008 10:41:23 -0500 [thread overview]
Message-ID: <49355723.8000200@harris.com> (raw)
In-Reply-To: <BD75FAE9-7D10-488B-9906-23B2D93F1FB6@kernel.crashing.org>
Kumar Gala wrote:
>
>
> On Dec 1, 2008, at 12:01 AM, Benjamin Herrenschmidt wrote:
>
>> We were missing the CPU_FTR_NOEXECUTE bit in our cputable for all
>> these processors. The result is that update_mmu_cache() would flush
>> the cache for all pages mapped to userspace which is totally
>> unnecessary on those processors since we already handle flushing
>> on execute in the page fault path.
>>
>> This should provide a nice speed up ;-)
>>
>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
I'm running with your patch on a 440 Sequoia board, and it
works fine for me.
Acked-by: Steven A. Falco <sfalco@harris.com>
Steve
prev parent reply other threads:[~2008-12-02 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 6:01 [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors Benjamin Herrenschmidt
2008-12-02 7:36 ` Kumar Gala
2008-12-02 9:20 ` Benjamin Herrenschmidt
2008-12-03 23:09 ` Trent Piepho
2008-12-04 0:06 ` Benjamin Herrenschmidt
2008-12-02 15:41 ` Steven A. Falco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49355723.8000200@harris.com \
--to=sfalco@harris.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.