[Ocfs2-devel] [nov 29] what is ocfs2_lock() used for ?

[Ocfs2-devel] [nov 29] what is ocfs2_lock() used for ?

[Coly Li]

Hi List,

In Linus tree, I find ocfs2_lock() in fs/ocfs2/locks.c, this function can not be found from sles10
sp2 tree. Also I don't find any other code calling ocfs2_lock().

Can anybody tell me, what is ocfs2_lock() used for ?

Thanks.
-- 
Coly Li
SuSE PRC Labs

[Ocfs2-devel] [nov 29] what is ocfs2_lock() used for ?

[Tao Ma]

Coly Li wrote:
> Hi List,
> 
> In Linus tree, I find ocfs2_lock() in fs/ocfs2/locks.c, this function can not be found from sles10
> sp2 tree. Also I don't find any other code calling ocfs2_lock().
It is an operation in file_operations. git log fs/ocfs2/locks.c shows 
that it is added by commit 53da4939f349d4edd283b043219221ca5b78e4d4.

commit 53da4939f349d4edd283b043219221ca5b78e4d4
Author: Mark Fasheh <mfasheh@suse.com>
Date:   Mon Jul 21 14:29:16 2008 -0700

     ocfs2: POSIX file locks support

     This is actually pretty easy since fs/dlm already handles the bulk 
of the work. The Ocfs2 userspace cluster stack module already uses 
fs/dlm as the underlying lock manager, so I only had to add the right calls.

     Cluster-aware POSIX locks ("plocks") can be turned off by the same 
means at UNIX locks - mount with 'noflocks', or create a local-only 
Ocfs2 volume. Internally, the file system uses two sets of 
file_operations, depending on whether cluster aware plocks is required. 
This turns out to be easier than implementing local-only versions of ->lock.

     Signed-off-by: Mark Fasheh <mfasheh@suse.com>

Regards,
Tao

[Ocfs2-devel] [nov 29] what is ocfs2_lock() used for ?

[Sunil Mushran]

SLES10 SP2 is shipping OCFS2 1.4 + few HASF specific patches.

If you want to see how 1.4 maps to ocfs2 in mainline, review the shortlog
on the 1.4 git tree. It tells you the full story.
http://oss.oracle.com/git/?p=ocfs2-1.4.git;a=summary

As Tao has already posted, ocfs2_lock() adds posix lock support, which was
added after 1.4 was released.

Sunil

Coly Li wrote:
> Hi List,
>
> In Linus tree, I find ocfs2_lock() in fs/ocfs2/locks.c, this function can not be found from sles10
> sp2 tree. Also I don't find any other code calling ocfs2_lock().
>
> Can anybody tell me, what is ocfs2_lock() used for ?
>
> Thanks.

[Ocfs2-devel] [nov 29] what is ocfs2_lock() used for ?

[Coly Li]

Tao Ma Wrote:
> 
> 
> Coly Li wrote:
>> Hi List,
>>
>> In Linus tree, I find ocfs2_lock() in fs/ocfs2/locks.c, this function
>> can not be found from sles10
>> sp2 tree. Also I don't find any other code calling ocfs2_lock().
> It is an operation in file_operations. git log fs/ocfs2/locks.c shows
> that it is added by commit 53da4939f349d4edd283b043219221ca5b78e4d4.
> 
> commit 53da4939f349d4edd283b043219221ca5b78e4d4
> Author: Mark Fasheh <mfasheh@suse.com>
> Date:   Mon Jul 21 14:29:16 2008 -0700
> 
>     ocfs2: POSIX file locks support
> 
>     This is actually pretty easy since fs/dlm already handles the bulk
> of the work. The Ocfs2 userspace cluster stack module already uses
> fs/dlm as the underlying lock manager, so I only had to add the right
> calls.
> 
>     Cluster-aware POSIX locks ("plocks") can be turned off by the same
> means at UNIX locks - mount with 'noflocks', or create a local-only
> Ocfs2 volume. Internally, the file system uses two sets of
> file_operations, depending on whether cluster aware plocks is required.
> This turns out to be easier than implementing local-only versions of
> ->lock.
> 
>     Signed-off-by: Mark Fasheh <mfasheh@suse.com>

Thanks for your explaining, really helpful.

-- 
Coly Li
SuSE PRC Labs

[Ocfs2-devel] [nov 29] what is ocfs2_lock() used for ?

[Coly Li]

Sunil Mushran Wrote:
> SLES10 SP2 is shipping OCFS2 1.4 + few HASF specific patches.
> 
> If you want to see how 1.4 maps to ocfs2 in mainline, review the shortlog
> on the 1.4 git tree. It tells you the full story.
> http://oss.oracle.com/git/?p=ocfs2-1.4.git;a=summary
> 
> As Tao has already posted, ocfs2_lock() adds posix lock support, which was
> added after 1.4 was released.

I will check the information. Thanks for the helpful info :)


> Coly Li wrote:
>> Hi List,
>>
>> In Linus tree, I find ocfs2_lock() in fs/ocfs2/locks.c, this function
>> can not be found from sles10
>> sp2 tree. Also I don't find any other code calling ocfs2_lock().
>>
>> Can anybody tell me, what is ocfs2_lock() used for ?

-- 
Coly Li
SuSE PRC Labs