All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell Cattelan <cattelan@thebarn.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch 1/5] replace b_fspriv with b_mount
Date: Tue, 09 Dec 2008 14:04:52 -0600	[thread overview]
Message-ID: <493ECF64.7060800@thebarn.com> (raw)
In-Reply-To: <20081209094801.116064000@bombadil.infradead.org>

Christoph Hellwig wrote:

 >  Replace the b_fspriv pointer and it's ugly accessors with a properly 
 > types
 > xfs_mount pointer.  Also switch log reocvery over to it instead of using
 > b_fspriv for the mount pointer.


Not that I object to cleaning this stuff up, (it's messy and hard to follow)

But currently the code maps well on freebsd since it has a
b_fsprivate1-3 buf field and
the macros handle the setting reading currently.

Granted I could simply un-apply this change for freebsd  but I would
prefer we
keep un-needed differences to a minimum.

I would prefer if we came up with a structure that could be attached to
an opaque  b_data field
that would be able to hold all current private info.

Currently it looks like b_strat is used for wrapper functions that
either check the mp for shutdown or
iclog->ic_state & XLOG_STATE_IOERROR.
Maybe we can collapse b_strat,  fspriv2/3 into one structure that would
have something like a
can_io function that would either allow or disallow io.

We could clean up more of the buf macros then.

-Russell



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2008-12-09 20:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09  9:47 [patch 0/5] Patch queue for 2.6.29 Christoph Hellwig
2008-12-09  9:47 ` [patch 1/5] replace b_fspriv with b_mount Christoph Hellwig
2008-12-09  9:56   ` Martin Steigerwald
2008-12-09 20:04   ` Russell Cattelan [this message]
2008-12-09  9:47 ` [patch 2/5] simplify projid check in xfs_rename Christoph Hellwig
2008-12-09  9:47 ` [patch 3/5] resync headers with libxfs Christoph Hellwig
2008-12-10  3:28   ` Lachlan McIlroy
2008-12-09  9:47 ` [patch 4/5] add a FMODE flag to make XFS invisible I/O less hacky Christoph Hellwig
2008-12-10  3:27   ` Lachlan McIlroy
2008-12-09  9:47 ` [patch 5/5] use inode_change_ok for setattr permission checking Christoph Hellwig
2008-12-10  3:40   ` Lachlan McIlroy
2008-12-10  5:09   ` Timothy Shimmin
2008-12-09  9:57 ` [patch 0/5] Patch queue for 2.6.29 Martin Steigerwald
2008-12-09 10:07   ` Christoph Hellwig
2008-12-09 11:02     ` Martin Steigerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493ECF64.7060800@thebarn.com \
    --to=cattelan@thebarn.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.