All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timothy Shimmin <tes@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [patch 5/5] use inode_change_ok for setattr permission checking
Date: Wed, 10 Dec 2008 16:09:06 +1100	[thread overview]
Message-ID: <493F4EF2.1020300@sgi.com> (raw)
In-Reply-To: <20081209094801.643772000@bombadil.infradead.org>

Christoph Hellwig wrote:
> Instead of implementing our own checks use inode_change_ok to check for
> necessary permission in setattr.  There is a slight change in behaviour
> as inode_change_ok doesn't allow i_mode updates to add the suid or sgid
> without superuser privilegues while the old XFS code just stripped away
> those bits from the file mode.
> 
> (First sent on Semptember 29th)
(No reply from Question on Nov 12th:)

I just wanted to run this thru an amended xfstests/193 first.

Thanks,
--Tim

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2008-12-10  5:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09  9:47 [patch 0/5] Patch queue for 2.6.29 Christoph Hellwig
2008-12-09  9:47 ` [patch 1/5] replace b_fspriv with b_mount Christoph Hellwig
2008-12-09  9:56   ` Martin Steigerwald
2008-12-09 20:04   ` Russell Cattelan
2008-12-09  9:47 ` [patch 2/5] simplify projid check in xfs_rename Christoph Hellwig
2008-12-09  9:47 ` [patch 3/5] resync headers with libxfs Christoph Hellwig
2008-12-10  3:28   ` Lachlan McIlroy
2008-12-09  9:47 ` [patch 4/5] add a FMODE flag to make XFS invisible I/O less hacky Christoph Hellwig
2008-12-10  3:27   ` Lachlan McIlroy
2008-12-09  9:47 ` [patch 5/5] use inode_change_ok for setattr permission checking Christoph Hellwig
2008-12-10  3:40   ` Lachlan McIlroy
2008-12-10  5:09   ` Timothy Shimmin [this message]
2008-12-09  9:57 ` [patch 0/5] Patch queue for 2.6.29 Martin Steigerwald
2008-12-09 10:07   ` Christoph Hellwig
2008-12-09 11:02     ` Martin Steigerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493F4EF2.1020300@sgi.com \
    --to=tes@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.