Re: [PATCH 3/5] iommu/ipmmu-vmsa: Add device tree support

[Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>]

Hi Geert,

On Monday 31 March 2014 10:45:00 Geert Uytterhoeven wrote:
> On Sat, Mar 29, 2014 at 12:36 AM, Laurent Pinchart wrote:
> > @@ -828,16 +829,31 @@ static phys_addr_t ipmmu_iova_to_phys(struct
> > iommu_domain *io_domain,> 
> >  static int ipmmu_find_utlb(struct ipmmu_vmsa_device *mmu, struct device
> >  *dev) {
> > 
> > +       ret = of_parse_phandle_with_fixed_args(dev->of_node, "iommus",
> > +                                              1, 0, &args);
> 
> drivers/of/base.c:of_parse_phandle_with_fixed_args():
> 
> "Caller is responsible to call of_node_put() on the returned out_args->node
>  pointer."

Thank you for the review. I'll fix that in v2.

> > +       if (ret < 0)
> > +               return -1;
> > +
> > +       if (args.np != mmu->dev->of_node)
> > +               return -1;
> > +
> > +       return args.args[0];
> >  }

- 
Regards,

Laurent Pinchart