From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Ingo Molnar <mingo@elte.hu>, xen-devel@lists.xensource.com
Subject: Re: Re: [PATCH] x86: fix the potential of encounteringpanic "IO-APIC + timer doesn't work! ..."
Date: Fri, 12 Dec 2008 09:54:17 +0000 [thread overview]
Message-ID: <494242D9.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C567E14B.20275%keir.fraser@eu.citrix.com>
>>> Keir Fraser <keir.fraser@eu.citrix.com> 12.12.08 10:37 >>>
>On 12/12/2008 09:24, "Ingo Molnar" <mingo@elte.hu> wrote:
>
>>>> note that we had to revert that eventually. The real solution is an
>>>> array of fixes from Maciej spread out over many months.
>>>
>>> Does it do more harm than good on some systems, or is it simply not a
>>> comprehensive fix?
>>
>> more harm than good - fixes some, breaks others. Have a look at the
>> latest upstream io_apic.c, that has it all settled down reasonably well.
>
>Thanks, Ingo.
>
>Jan: Do you agree we should revert the io_apic.c changes, but keep your
>addition of an explicit local_irq_enable() to __start_xen()?
No, please don't until Ingo clarified his indication of this having got
reverted (see my other response to him). I really can't see why properly
enabling/disabling interrupts in that code could do any harm.
Jan
next prev parent reply other threads:[~2008-12-12 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 10:39 [PATCH] x86: fix the potential of encountering panic "IO-APIC + timer doesn't work! ..." Jan Beulich
2008-12-11 11:14 ` Keir Fraser
2008-12-12 9:13 ` Ingo Molnar
2008-12-12 9:23 ` Keir Fraser
2008-12-12 9:24 ` Ingo Molnar
2008-12-12 9:37 ` Keir Fraser
2008-12-12 9:54 ` Jan Beulich [this message]
2008-12-12 9:50 ` [PATCH] x86: fix the potential of encountering panic "IO-APIC+ " Jan Beulich
2008-12-12 10:06 ` Ingo Molnar
2008-12-12 10:37 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494242D9.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.