From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Cc: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] x86: fix the potential of encountering panic "IO-APIC + timer doesn't work! ..."
Date: Thu, 11 Dec 2008 11:14:23 +0000 [thread overview]
Message-ID: <C566A68F.B49%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4940FBFA.76E4.0078.0@novell.com>
On 11/12/2008 10:39, "Jan Beulich" <jbeulich@novell.com> wrote:
> I have to admit that in addition I find it quite disturbing that there
> is a dependency on the side effect of smp_prepare_cpus()
> (check_nmi_watchdog() or until now setup_IO_APIC()) or init_xen_time()
> (init_platform_timer() -> plt_overflow()) enabling interrupts: c/s 5604
> removed the explicit local_irq_enable() from start_of_day() (which is
> __start_xen() now), putting it into init_xen_time(). There it got
> removed by c/s 18698, without an explicit replacement. I'd think there
> should be an explicit local_irq_enable() in __start_xen() in any case,
> and as early as reasonable (i.e. the latest before smp_prepare_cpus()).
Sounds reasonable. Send a patch.
-- Keir
next prev parent reply other threads:[~2008-12-11 11:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 10:39 [PATCH] x86: fix the potential of encountering panic "IO-APIC + timer doesn't work! ..." Jan Beulich
2008-12-11 11:14 ` Keir Fraser [this message]
2008-12-12 9:13 ` Ingo Molnar
2008-12-12 9:23 ` Keir Fraser
2008-12-12 9:24 ` Ingo Molnar
2008-12-12 9:37 ` Keir Fraser
2008-12-12 9:54 ` Re: [PATCH] x86: fix the potential of encounteringpanic " Jan Beulich
2008-12-12 9:50 ` [PATCH] x86: fix the potential of encountering panic "IO-APIC+ " Jan Beulich
2008-12-12 10:06 ` Ingo Molnar
2008-12-12 10:37 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C566A68F.B49%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.