From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Yangbo Lu <yangbo.lu@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-i2c@vger.kernel.org, iommu@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org, Zhao Qiang <qiang.zhao@freescale.com>,
Russell King <linux@arm.linux.org.uk>,
Bhupesh Sharma <bhupesh.sharma@freescale.com>,
Joerg Roedel <joro@8bytes.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
scott.wood@nxp.com, Rob Herring <robh+dt@kernel.org>,
Claudiu Manoil <claudiu.manoil@freescale.com>,
Kumar Gala <galak@codeaurora.org>,
leoyang.li@nxp.com, xiaobo.xie@nxp.com
Subject: Re: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0
Date: Sun, 13 Mar 2016 23:26:28 +0100 [thread overview]
Message-ID: <4947024.WeMycs2fID@wuerfel> (raw)
In-Reply-To: <1457518131-11339-6-git-send-email-yangbo.lu@nxp.com>
On Wednesday 09 March 2016 18:08:51 Yangbo Lu wrote:
> @@ -567,10 +580,20 @@ static void esdhc_init(struct platform_device *pdev, struct sdhci_host *host)
> struct sdhci_pltfm_host *pltfm_host;
> struct sdhci_esdhc *esdhc;
> u16 host_ver;
> + u32 svr;
>
> pltfm_host = sdhci_priv(host);
> esdhc = sdhci_pltfm_priv(pltfm_host);
>
> + fsl_guts_init();
> + svr = fsl_guts_get_svr();
> + if (svr) {
> + esdhc->soc_ver = SVR_SOC_VER(svr);
> + esdhc->soc_rev = SVR_REV(svr);
> + } else {
> + dev_err(&pdev->dev, "Failed to get SVR value!\n");
> + }
> +
This makes the driver non-portable. Better identify the specific workarounds
based on the compatible string for this device, or add a boolean DT property
for the quirk.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0
Date: Sun, 13 Mar 2016 23:26:28 +0100 [thread overview]
Message-ID: <4947024.WeMycs2fID@wuerfel> (raw)
In-Reply-To: <1457518131-11339-6-git-send-email-yangbo.lu@nxp.com>
On Wednesday 09 March 2016 18:08:51 Yangbo Lu wrote:
> @@ -567,10 +580,20 @@ static void esdhc_init(struct platform_device *pdev, struct sdhci_host *host)
> struct sdhci_pltfm_host *pltfm_host;
> struct sdhci_esdhc *esdhc;
> u16 host_ver;
> + u32 svr;
>
> pltfm_host = sdhci_priv(host);
> esdhc = sdhci_pltfm_priv(pltfm_host);
>
> + fsl_guts_init();
> + svr = fsl_guts_get_svr();
> + if (svr) {
> + esdhc->soc_ver = SVR_SOC_VER(svr);
> + esdhc->soc_rev = SVR_REV(svr);
> + } else {
> + dev_err(&pdev->dev, "Failed to get SVR value!\n");
> + }
> +
This makes the driver non-portable. Better identify the specific workarounds
based on the compatible string for this device, or add a boolean DT property
for the quirk.
Arnd
next prev parent reply other threads:[~2016-03-13 22:27 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 10:08 [v6, 0/5] Fix eSDHC host version register bug Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` [v6, 1/5] ARM64: dts: ls2080a: add device configuration node Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` [v6, 2/5] soc: fsl: add GUTS driver for QorIQ platforms Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-18 22:54 ` Scott Wood
2016-03-18 22:54 ` Scott Wood
2016-03-18 22:54 ` Scott Wood
2016-03-18 22:54 ` Scott Wood
2016-03-25 6:44 ` Yangbo Lu
2016-03-25 6:44 ` Yangbo Lu
2016-03-25 6:44 ` Yangbo Lu
2016-03-25 6:44 ` Yangbo Lu
2016-03-25 6:44 ` Yangbo Lu
2016-03-09 10:08 ` [v6, 3/5] dt: move guts devicetree doc out of powerpc directory Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-17 17:06 ` Rob Herring
2016-03-17 17:06 ` Rob Herring
2016-03-17 17:11 ` Arnd Bergmann
2016-03-17 17:11 ` Arnd Bergmann
2016-03-17 17:57 ` Rob Herring
2016-03-17 17:57 ` Rob Herring
2016-03-17 17:57 ` Rob Herring
2016-03-17 17:57 ` Rob Herring
2016-03-17 21:33 ` Leo Li
2016-03-17 21:33 ` Leo Li
2016-03-17 21:33 ` Leo Li
2016-03-17 21:33 ` Leo Li
2016-03-18 18:16 ` Scott Wood
2016-03-18 18:16 ` Scott Wood
2016-03-18 18:16 ` Scott Wood
2016-03-18 18:16 ` Scott Wood
2016-03-18 18:16 ` Scott Wood
2016-03-25 6:38 ` Yangbo Lu
2016-03-25 6:38 ` Yangbo Lu
2016-03-25 6:38 ` Yangbo Lu
2016-03-25 6:38 ` Yangbo Lu
2016-03-25 6:38 ` Yangbo Lu
2016-03-25 6:38 ` Yangbo Lu
2016-03-09 10:08 ` [v6, 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-12 15:52 ` Wolfram Sang
2016-03-12 15:52 ` Wolfram Sang
2016-03-09 10:08 ` [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-09 10:08 ` Yangbo Lu
2016-03-13 22:26 ` Arnd Bergmann [this message]
2016-03-13 22:26 ` Arnd Bergmann
2016-03-14 7:29 ` Yangbo Lu
2016-03-14 7:29 ` Yangbo Lu
2016-03-14 7:29 ` Yangbo Lu
2016-03-14 7:29 ` Yangbo Lu
2016-03-14 7:29 ` Yangbo Lu
2016-03-14 17:45 ` Scott Wood
2016-03-14 17:45 ` Scott Wood
2016-03-14 17:45 ` Scott Wood
2016-03-14 17:45 ` Scott Wood
2016-03-14 17:45 ` Scott Wood
2016-03-17 17:01 ` Rob Herring
2016-03-17 17:01 ` Rob Herring
2016-03-17 17:01 ` Rob Herring
2016-03-17 17:01 ` Rob Herring
2016-03-17 17:06 ` Arnd Bergmann
2016-03-17 17:06 ` Arnd Bergmann
2016-03-17 17:06 ` Arnd Bergmann
2016-03-17 17:06 ` Arnd Bergmann
2016-03-17 17:06 ` Arnd Bergmann
2016-03-18 18:28 ` Scott Wood
2016-03-18 18:28 ` Scott Wood
2016-03-18 18:28 ` Scott Wood
2016-03-18 18:28 ` Scott Wood
2016-03-25 6:43 ` Yangbo Lu
2016-03-25 6:43 ` Yangbo Lu
2016-03-25 6:43 ` Yangbo Lu
2016-03-25 6:43 ` Yangbo Lu
2016-03-25 6:43 ` Yangbo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4947024.WeMycs2fID@wuerfel \
--to=arnd@arndb.de \
--cc=bhupesh.sharma@freescale.com \
--cc=claudiu.manoil@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=qiang.zhao@freescale.com \
--cc=robh+dt@kernel.org \
--cc=scott.wood@nxp.com \
--cc=ssantosh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xiaobo.xie@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.