[Adeos-main] [PATCH] x86-2.6.27: Cleanup redundant mtrr hunk

[Adeos-main] [PATCH] x86-2.6.27: Cleanup redundant mtrr hunk

[Jan Kiszka]

Likely a merge artifact: IRQs are already reenabled a few lines above
this hunk.

Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>

---
 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/arch/x86/kernel/cpu/mtrr/generic.c
===================================================================
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -575,7 +575,7 @@ static void generic_set_all(void)
 			set_bit(count, &smp_changes_mask);
 		mask >>= 1;
 	}
-	local_irq_restore_hw(flags);
+	
 }
 
 static void generic_set_mtrr(unsigned int reg, unsigned long base,

Re: [Adeos-main] [PATCH] x86-2.6.27: Cleanup redundant mtrr hunk

[Roberto Bucher]

I rebooted my laptop 10 minutes ago and the problem happens again!

Roberto

On Tuesday 16 December 2008 10:43:48 Jan Kiszka wrote:
> Likely a merge artifact: IRQs are already reenabled a few lines above
> this hunk.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>
> ---
>  arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/arch/x86/kernel/cpu/mtrr/generic.c
> ===================================================================
> --- a/arch/x86/kernel/cpu/mtrr/generic.c
> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -575,7 +575,7 @@ static void generic_set_all(void)
>  			set_bit(count, &smp_changes_mask);
>  		mask >>= 1;
>  	}
> -	local_irq_restore_hw(flags);
> +
>  }
>
>  static void generic_set_mtrr(unsigned int reg, unsigned long base,
>
> _______________________________________________
> Adeos-main mailing list
> Adeos-main@domain.hid
> https://mail.gna.org/listinfo/adeos-main

-- 
University of Applied Sciences of Southern Switzerland
Dept. Innovative Technologies
CH-6928 Lugano-Manno
http://web.dti.supsi.ch/~bucher

Re: [Adeos-main] [PATCH] x86-2.6.27: Cleanup redundant mtrr hunk

[Jan Kiszka]

Roberto Bucher wrote:
> I rebooted my laptop 10 minutes ago and the problem happens again!
> 

Grmbl. Still no chance to get hold of an oops message?

Jan

> Roberto
> 
> On Tuesday 16 December 2008 10:43:48 Jan Kiszka wrote:
>> Likely a merge artifact: IRQs are already reenabled a few lines above
>> this hunk.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>>
>> ---
>>  arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: b/arch/x86/kernel/cpu/mtrr/generic.c
>> ===================================================================
>> --- a/arch/x86/kernel/cpu/mtrr/generic.c
>> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
>> @@ -575,7 +575,7 @@ static void generic_set_all(void)
>>  			set_bit(count, &smp_changes_mask);
>>  		mask >>= 1;
>>  	}
>> -	local_irq_restore_hw(flags);
>> +
>>  }
>>
>>  static void generic_set_mtrr(unsigned int reg, unsigned long base,
>>
>> _______________________________________________
>> Adeos-main mailing list
>> Adeos-main@domain.hid
>> https://mail.gna.org/listinfo/adeos-main
> 

-- 
Siemens AG, Corporate Technology, CT SE 26
Corporate Competence Center Embedded Linux

Re: [Adeos-main] [PATCH] x86-2.6.27: Cleanup redundant mtrr hunk

[Roberto Bucher]

I'm sorry but my system freezes without giving some info in the log files...

I don't know exactly what I can do: basically I can reproduce the error, but I 
can't catch any log info about.

Roberto

On Tuesday 16 December 2008 13:49:23 you wrote:
> Roberto Bucher wrote:
> > I rebooted my laptop 10 minutes ago and the problem happens again!
>
> Grmbl. Still no chance to get hold of an oops message?
>
> Jan
>
> > Roberto
> >
> > On Tuesday 16 December 2008 10:43:48 Jan Kiszka wrote:
> >> Likely a merge artifact: IRQs are already reenabled a few lines above
> >> this hunk.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
> >>
> >> ---
> >>  arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Index: b/arch/x86/kernel/cpu/mtrr/generic.c
> >> ===================================================================
> >> --- a/arch/x86/kernel/cpu/mtrr/generic.c
> >> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
> >> @@ -575,7 +575,7 @@ static void generic_set_all(void)
> >>  			set_bit(count, &smp_changes_mask);
> >>  		mask >>= 1;
> >>  	}
> >> -	local_irq_restore_hw(flags);
> >> +
> >>  }
> >>
> >>  static void generic_set_mtrr(unsigned int reg, unsigned long base,
> >>
> >> _______________________________________________
> >> Adeos-main mailing list
> >> Adeos-main@domain.hid
> >> https://mail.gna.org/listinfo/adeos-main

-- 
University of Applied Sciences of Southern Switzerland
Dept. Innovative Technologies
CH-6928 Lugano-Manno
http://web.dti.supsi.ch/~bucher

Re: [Adeos-main] [PATCH] x86-2.6.27: Cleanup redundant mtrr hunk

[Jan Kiszka]

Roberto Bucher wrote:
> I'm sorry but my system freezes without giving some info in the log files...
> 
> I don't know exactly what I can do: basically I can reproduce the error, but I 
> can't catch any log info about.
> 

Please have a look at linux/Documentation/serial-console.txt or
linux/Documentation/networking/netconsole.txt.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 26
Corporate Competence Center Embedded Linux