[lm-sensors] PATCH: f71882fg: fix fan_to/from_reg prototypes

[lm-sensors] PATCH: f71882fg: fix fan_to/from_reg prototypes

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Hi Jean,

The RPM after conversion from / before conversion to a register value can be
much more then 65535 (up to 1500000), so putting this into an u16 can cause
overflows. This changes the functions to use an int to store / get RPM instead.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

[-- Attachment #2: hwmon-f71882fg-18-fix-fan-reg-funcs.patch --]
[-- Type: text/plain, Size: 740 bytes --]

The RPM after conversion from / before conversion to a register value can be
much more then 65535 (up to 1500000), so putting this into an u16 can cause
overflows. This changes the functions to use an int to store / get RPM instead.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
--- f71882fg.c.17-applied	2008-12-15 16:30:57.000000000 +0100
+++ f71882fg.c	2008-12-16 17:14:53.000000000 +0100
@@ -810,12 +810,12 @@ static inline void superio_exit(int base
 	outb(SIO_LOCK_KEY, base);
 }
 
-static inline u16 fan_from_reg(u16 reg)
+static inline int fan_from_reg(u16 reg)
 {
 	return reg ? (1500000 / reg) : 0;
 }
 
-static inline u16 fan_to_reg(u16 fan)
+static inline u16 fan_to_reg(int fan)
 {
 	return fan ? (1500000 / fan) : 0;
 }

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: f71882fg: fix fan_to/from_reg prototypes

[Jean Delvare]

On Tue, 16 Dec 2008 17:18:24 +0100, Hans de Goede wrote:
> Hi Jean,
> 
> The RPM after conversion from / before conversion to a register value can be
> much more then 65535 (up to 1500000), so putting this into an u16 can cause
> overflows. This changes the functions to use an int to store / get RPM instead.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied, thanks.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors