All of lore.kernel.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v6 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings
Date: Tue, 04 Apr 2017 12:40:54 +0300	[thread overview]
Message-ID: <4948994.ktJJpZgFXr@avalon> (raw)
In-Reply-To: <1491230558-10804-5-git-send-email-narmstrong@baylibre.com>

Hi Neil,

Thank you for the patch.

On Monday 03 Apr 2017 16:42:36 Neil Armstrong wrote:
> Some display pipelines can only provide non-RBG input pixels to the HDMI TX
> Controller, this patch takes the pixel format from the plat_data if
> provided.

The commit message doesn't seem to match the subject line.

> Reviewed-by: Jose Abreu <joabreu@synopsys.com>
> Reviewed-by: Archit Taneja <architt@codeaurora.org>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 326 +++++++++++++++++++--------
>  include/drm/bridge/dw_hdmi.h              |  63 ++++++
>  2 files changed, 294 insertions(+), 95 deletions(-)

[snip]

> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
> index bcceee8..45c2c15 100644
> --- a/include/drm/bridge/dw_hdmi.h
> +++ b/include/drm/bridge/dw_hdmi.h
> @@ -14,6 +14,67 @@
>  
>  struct dw_hdmi;
>  
> +/**
> + * DOC: Supported input formats and encodings
> + *
> + * Depending on the Hardware configuration of the Controller IP, it
> supports
> + * a subset of the following input formats and encodings on it's internal
> + * 48bit bus.
> + *

s/it's/its/

[snip]

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: dri-devel@lists.freedesktop.org,
	laurent.pinchart+renesas@ideasonboard.com,
	architt@codeaurora.org, mchehab@kernel.org,
	Jose.Abreu@synopsys.com, kieran.bingham@ideasonboard.com,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-media@vger.kernel.org,
	hans.verkuil@cisco.com, sakari.ailus@linux.intel.com
Subject: Re: [PATCH v6 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings
Date: Tue, 04 Apr 2017 12:40:54 +0300	[thread overview]
Message-ID: <4948994.ktJJpZgFXr@avalon> (raw)
In-Reply-To: <1491230558-10804-5-git-send-email-narmstrong@baylibre.com>

Hi Neil,

Thank you for the patch.

On Monday 03 Apr 2017 16:42:36 Neil Armstrong wrote:
> Some display pipelines can only provide non-RBG input pixels to the HDMI TX
> Controller, this patch takes the pixel format from the plat_data if
> provided.

The commit message doesn't seem to match the subject line.

> Reviewed-by: Jose Abreu <joabreu@synopsys.com>
> Reviewed-by: Archit Taneja <architt@codeaurora.org>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 326 +++++++++++++++++++--------
>  include/drm/bridge/dw_hdmi.h              |  63 ++++++
>  2 files changed, 294 insertions(+), 95 deletions(-)

[snip]

> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
> index bcceee8..45c2c15 100644
> --- a/include/drm/bridge/dw_hdmi.h
> +++ b/include/drm/bridge/dw_hdmi.h
> @@ -14,6 +14,67 @@
>  
>  struct dw_hdmi;
>  
> +/**
> + * DOC: Supported input formats and encodings
> + *
> + * Depending on the Hardware configuration of the Controller IP, it
> supports
> + * a subset of the following input formats and encodings on it's internal
> + * 48bit bus.
> + *

s/it's/its/

[snip]

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2017-04-04  9:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03 14:42 [PATCH v6 0/6] drm: bridge: dw-hdmi: Add support for Custom PHYs Neil Armstrong
2017-04-03 14:42 ` Neil Armstrong
2017-04-03 14:42 ` [PATCH v6 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-03 14:42 ` [PATCH v6 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-04  9:11   ` Laurent Pinchart
2017-04-04  9:11     ` Laurent Pinchart
2017-04-04  9:11     ` Laurent Pinchart
2017-04-03 14:42 ` [PATCH v6 3/6] documentation: media: Add documentation for new RGB and YUV bus formats Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-04  9:18   ` Laurent Pinchart
2017-04-04  9:18     ` Laurent Pinchart
2017-04-03 14:42 ` [PATCH v6 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-04  9:40   ` Laurent Pinchart [this message]
2017-04-04  9:40     ` Laurent Pinchart
2017-04-03 14:42 ` [PATCH v6 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-04  9:41   ` Laurent Pinchart
2017-04-04  9:41     ` Laurent Pinchart
2017-04-04  9:41     ` Laurent Pinchart
2017-04-03 14:42 ` [PATCH v6 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-03 14:42   ` Neil Armstrong
2017-04-04  9:52   ` Laurent Pinchart
2017-04-04  9:52     ` Laurent Pinchart
2017-04-04  9:52     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4948994.ktJJpZgFXr@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.