From: Matthieu CASTET <matthieu.castet@parrot.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-serial@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
linux-kernel@vger.kernel.org
Subject: Re: s3c24xx : TIOCM_CTS handling problem
Date: Wed, 17 Dec 2008 14:27:02 +0100 [thread overview]
Message-ID: <4948FE26.90907@parrot.com> (raw)
In-Reply-To: <20081216141533.7bcc5c9b@lxorguk.ukuu.org.uk>
Hi Alan,
Alan Cox a écrit :
>>> And easy fix could be to always report TIOCM_CTS.
>>>
>> Ping ?
>>
>> The bug is still present on git tree and I have got no replies.
>
> Send patches instead then ;)
>
> If the chip can sense the CTS line then you could check on a timer event
May be it could be usefull to do something generic that call driver
get_mctrl instead of doing it in the driver (like it is done in
bfin_5xx, sa1100, ...)
> but it might be cleaner to add the functionality needed to allow a driver
> to say "always call my start_tx" method.
Or to say "recheck get_mctrl before my start_tx).
But have you got an idea how the driver could ask that to the serial core ?
flags in struct uart_port seems full.
Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Matthieu CASTET <matthieu.castet@parrot.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-serial@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
linux-kernel@vger.kernel.org
Subject: Re: s3c24xx : TIOCM_CTS handling problem
Date: Wed, 17 Dec 2008 14:27:02 +0100 [thread overview]
Message-ID: <4948FE26.90907@parrot.com> (raw)
In-Reply-To: <20081216141533.7bcc5c9b@lxorguk.ukuu.org.uk>
Hi Alan,
Alan Cox a écrit :
>>> And easy fix could be to always report TIOCM_CTS.
>>>
>> Ping ?
>>
>> The bug is still present on git tree and I have got no replies.
>
> Send patches instead then ;)
>
> If the chip can sense the CTS line then you could check on a timer event
May be it could be usefull to do something generic that call driver
get_mctrl instead of doing it in the driver (like it is done in
bfin_5xx, sa1100, ...)
> but it might be cleaner to add the functionality needed to allow a driver
> to say "always call my start_tx" method.
Or to say "recheck get_mctrl before my start_tx).
But have you got an idea how the driver could ask that to the serial core ?
flags in struct uart_port seems full.
Matthieu
next prev parent reply other threads:[~2008-12-17 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 12:00 s3c24xx : TIOCM_CTS handling problem Matthieu CASTET
2008-09-25 13:14 ` better Documentation for TIOCM_CTS handling Matthieu CASTET
2008-12-16 13:43 ` s3c24xx : TIOCM_CTS handling problem Matthieu CASTET
2008-12-16 13:43 ` Matthieu CASTET
2008-12-16 14:15 ` Alan Cox
2008-12-17 13:27 ` Matthieu CASTET [this message]
2008-12-17 13:27 ` Matthieu CASTET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4948FE26.90907@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.