From: Tom Tucker <tom@opengridcomputing.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Ian Campbell <ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
linux-nfs@vger.kernel.org,
Max Kellermann <mk-xMchvyqCc6DQT0dZR+AlfA@public.gmane.org>,
linux-kernel@vger.kernel.org, gcosta@redhat.com,
Grant Coady <grant_lkml-rGYn+TmxqGy6c6uEtOJ/EA@public.gmane.org>,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH 1/3] SUNRPC: Ensure the server closes sockets in a timely fashion
Date: Wed, 17 Dec 2008 12:59:09 -0600 [thread overview]
Message-ID: <49494BFD.6000909@opengridcomputing.com> (raw)
In-Reply-To: <1229537296.7257.37.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
Trond Myklebust wrote:
> On Wed, 2008-12-17 at 09:27 -0600, Tom Tucker wrote:
>>> + if (!test_bit(XPT_LISTENER, &xprt->xpt_flags))
>>> + kernel_sock_shutdown(svsk->sk_sock, SHUT_RDWR);
>> How is this different than what happens as an artifact of sock_release?
>
> The point is that it is independent of whether or not something is
> holding a reference to the svc_sock.
Thanks, makes sense.
>
WARNING: multiple messages have this Message-ID (diff)
From: Tom Tucker <tom@opengridcomputing.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Ian Campbell <ijc@hellion.org.uk>,
linux-nfs@vger.kernel.org, Max Kellermann <mk@cm4all.com>,
linux-kernel@vger.kernel.org, gcosta@redhat.com,
Grant Coady <grant_lkml@dodo.com.au>,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH 1/3] SUNRPC: Ensure the server closes sockets in a timely fashion
Date: Wed, 17 Dec 2008 12:59:09 -0600 [thread overview]
Message-ID: <49494BFD.6000909@opengridcomputing.com> (raw)
In-Reply-To: <1229537296.7257.37.camel@heimdal.trondhjem.org>
Trond Myklebust wrote:
> On Wed, 2008-12-17 at 09:27 -0600, Tom Tucker wrote:
>>> + if (!test_bit(XPT_LISTENER, &xprt->xpt_flags))
>>> + kernel_sock_shutdown(svsk->sk_sock, SHUT_RDWR);
>> How is this different than what happens as an artifact of sock_release?
>
> The point is that it is independent of whether or not something is
> holding a reference to the svc_sock.
Thanks, makes sense.
>
next prev parent reply other threads:[~2008-12-17 18:59 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 12:32 [PATCH] NFS regression in 2.6.26?, "task blocked for more than 120 seconds" Max Kellermann
2008-10-17 14:33 ` Glauber Costa
2008-10-20 6:51 ` Max Kellermann
2008-10-20 7:43 ` Ian Campbell
2008-10-20 13:15 ` Glauber Costa
2008-10-20 14:12 ` Max Kellermann
2008-10-20 14:34 ` Cyrill Gorcunov
2008-10-20 14:21 ` Cyrill Gorcunov
2009-05-22 20:59 ` H. Peter Anvin
2009-05-25 13:12 ` Max Kellermann
2008-10-20 6:27 ` Ian Campbell
2008-11-01 11:45 ` Ian Campbell
2008-11-01 13:41 ` Trond Myklebust
2008-11-02 14:40 ` Ian Campbell
2008-11-07 2:12 ` kenneth johansson
2008-11-04 19:10 ` Ian Campbell
2008-11-25 7:09 ` Ian Campbell
[not found] ` <1227596962.16868.22.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-25 13:28 ` Trond Myklebust
2008-11-25 13:28 ` Trond Myklebust
[not found] ` <1227619696.7057.19.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-11-25 13:38 ` Ian Campbell
2008-11-25 13:38 ` Ian Campbell
[not found] ` <1227620339.9425.99.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2008-11-25 13:57 ` Trond Myklebust
2008-11-25 13:57 ` Trond Myklebust
[not found] ` <1227621434.7057.33.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-11-25 14:04 ` Ian Campbell
2008-11-25 14:04 ` Ian Campbell
[not found] ` <1227621877.9425.102.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2008-11-26 22:12 ` Ian Campbell
2008-11-26 22:12 ` Ian Campbell
[not found] ` <1227737539.31008.2.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-12-01 0:17 ` [PATCH 0/3] " Trond Myklebust
2008-12-01 0:17 ` Trond Myklebust
[not found] ` <1228090631.7112.11.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-01 0:18 ` [PATCH 1/3] SUNRPC: Ensure the server closes sockets in a timely fashion Trond Myklebust
2008-12-01 0:18 ` Trond Myklebust
[not found] ` <1228090719.7112.13.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-17 15:27 ` Tom Tucker
2008-12-17 15:27 ` Tom Tucker
2008-12-17 18:08 ` Trond Myklebust
2008-12-17 18:08 ` Trond Myklebust
[not found] ` <1229537296.7257.37.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-17 18:59 ` Tom Tucker [this message]
2008-12-17 18:59 ` Tom Tucker
2008-12-01 0:20 ` [PATCH 3/3] SUNRPC: svc_xprt_enqueue should not refuse to enqueue 'XPT_DEAD' transports Trond Myklebust
2008-12-01 0:20 ` Trond Myklebust
2008-12-17 15:35 ` Tom Tucker
2008-12-17 19:07 ` Trond Myklebust
2008-12-17 19:07 ` Trond Myklebust
[not found] ` <1229540877.7257.97.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-23 14:49 ` Tom Tucker
2008-12-23 14:49 ` Tom Tucker
2008-12-23 23:39 ` Tom Tucker
2008-12-23 23:39 ` Tom Tucker
2009-01-02 21:44 ` Tom Tucker
2009-01-04 19:12 ` Trond Myklebust
[not found] ` <1231096358.7363.6.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-04 19:25 ` Trond Myklebust
2009-01-05 3:33 ` Tom Tucker
[not found] ` <1231097131.7 363.11.camel@heimdal.trondhjem.org>
[not found] ` <1231097131.7363.11.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-05 3:33 ` Tom Tucker
2009-01-05 17:04 ` Tom Tucker
2009-01-05 17:13 ` Trond Myklebust
[not found] ` <1231175613.7127.6.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-05 19:33 ` Tom Tucker
2009-01-05 19:51 ` Trond Myklebust
[not found] ` <1231185115.7127.28.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-05 20:13 ` Tom Tucker
2009-01-05 20:41 ` Tom Tucker
2009-01-05 20:48 ` Trond Myklebust
[not found] ` <1231188518.7127.30.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-05 21:10 ` Tom Tucker
2008-12-01 0:29 ` [PATCH 0/3] NFS regression in 2.6.26?, "task blocked for more than 120 seconds" Trond Myklebust
2008-12-01 0:29 ` Trond Myklebust
[not found] ` <1228091380.7112.17.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-02 15:22 ` Kasparek Tomas
2008-12-02 15:22 ` Kasparek Tomas
2008-12-02 15:37 ` Trond Myklebust
2008-12-02 15:37 ` Trond Myklebust
[not found] ` <1228232222.3090.5.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-02 16:26 ` Kasparek Tomas
2008-12-02 16:26 ` Kasparek Tomas
2008-12-02 18:10 ` Trond Myklebust
2008-12-02 18:10 ` Trond Myklebust
[not found] ` <1228241407.3090.7.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-04 10:23 ` Kasparek Tomas
[not found] ` <1229284201.6463.98.camel@heimdal.trondhjem.org>
[not found] ` <1229284201.6463.98.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-12-16 12:05 ` Kasparek Tomas
2008-12-16 12:10 ` Kasparek Tomas
2008-12-16 12:59 ` Trond Myklebust
2008-12-23 22:34 ` Trond Myklebust
[not found] ` <1230071647.17701.27.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-05 12:18 ` Kasparek Tomas
2009-01-09 14:56 ` Kasparek Tomas
2009-01-09 17:59 ` Trond Myklebust
[not found] ` <1231523966.7179.67.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-10 10:24 ` Kasparek Tomas
2009-01-10 16:00 ` Trond Myklebust
[not found] ` <20090112090404.GL47559@fit.vutbr.cz>
[not found] ` <1231782009.7322.12.camel@heimdal.trondhjem.org>
[not found] ` <1231809446.7322.17.camel@heimdal.trondhjem.org>
[not found] ` <1231809446.7322.17.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-13 15:22 ` Kasparek Tomas
2009-01-16 10:48 ` Kasparek Tomas
2009-01-18 13:08 ` Kasparek Tomas
2009-01-20 15:03 ` Kasparek Tomas
2009-01-20 15:32 ` Trond Myklebust
[not found] ` <1232465547.7055.3.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-28 8:18 ` Kasparek Tomas
2009-02-06 6:35 ` Kasparek Tomas
2009-02-10 7:55 ` Kasparek Tomas
2009-03-03 12:08 ` Kasparek Tomas
2009-03-03 14:16 ` Trond Myklebust
[not found] ` <1236089767.9631.4.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-03-25 8:46 ` Kasparek Tomas
2009-04-18 5:17 ` Kasparek Tomas
2009-04-22 17:27 ` NFS client packet storm on 2.6.27.x Kasparek Tomas
2009-04-22 17:27 ` Kasparek Tomas
2009-04-29 12:12 ` Steve Dickson
[not found] ` <49F84436.5090007-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-04-29 14:57 ` Kasparek Tomas
2009-04-29 14:57 ` Kasparek Tomas
2009-06-25 5:55 ` Kasparek Tomas
2009-06-25 5:55 ` Kasparek Tomas
2009-07-13 11:12 ` Kasparek Tomas
2009-07-13 11:12 ` Kasparek Tomas
2009-07-13 17:20 ` [stable] " Greg KH
2009-07-13 17:40 ` Trond Myklebust
[not found] ` <1247506817.14524.25.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-07-24 8:54 ` Kasparek Tomas
2009-07-28 18:31 ` Greg KH
2009-07-28 18:31 ` Greg KH
2008-12-01 22:09 ` [PATCH 0/3] NFS regression in 2.6.26?, "task blocked for more than 120 seconds" Ian Campbell
2008-12-01 22:09 ` Ian Campbell
[not found] ` <1228169383.20370.3.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-12-06 12:16 ` Ian Campbell
2008-12-06 12:16 ` Ian Campbell
[not found] ` <1228565812.10856.30.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-12-14 18:24 ` Ian Campbell
2008-12-14 18:24 ` Ian Campbell
[not found] ` <1229279045.3721.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-12-16 17:55 ` J. Bruce Fields
2008-12-16 17:55 ` J. Bruce Fields
2008-12-16 18:39 ` Ian Campbell
2008-12-16 18:39 ` Ian Campbell
[not found] ` <1229452775.3721.25.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-07 22:21 ` J. Bruce Fields
2009-01-07 22:21 ` J. Bruce Fields
2009-01-08 18:20 ` J. Bruce Fields
2009-01-08 18:20 ` J. Bruce Fields
2009-01-08 21:22 ` Ian Campbell
2009-01-08 21:22 ` Ian Campbell
[not found] ` <1231449753.21688.12.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-08 21:26 ` J. Bruce Fields
2009-01-08 21:26 ` J. Bruce Fields
2009-01-12 9:46 ` Ian Campbell
2009-01-12 9:46 ` Ian Campbell
2009-01-22 8:27 ` Ian Campbell
2009-01-22 8:27 ` Ian Campbell
[not found] ` <1232612860.29604.57.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-22 16:44 ` J. Bruce Fields
2009-01-22 16:44 ` J. Bruce Fields
2008-12-01 0:19 ` [PATCH 2/3] SUNRPC: We only need to call svc_delete_xprt() once Trond Myklebust
2008-11-26 9:16 ` [PATCH] NFS regression in 2.6.26?, Tomas Kasparek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49494BFD.6000909@opengridcomputing.com \
--to=tom@opengridcomputing.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=gcosta@redhat.com \
--cc=grant_lkml-rGYn+TmxqGy6c6uEtOJ/EA@public.gmane.org \
--cc=ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mk-xMchvyqCc6DQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.