From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com
Subject: Re: [PATCH 5/5] cache slot lookup
Date: Thu, 18 Dec 2008 13:24:47 +0200 [thread overview]
Message-ID: <494A32FF.80103@redhat.com> (raw)
In-Reply-To: <20081218104850.GB19123@poweredge.glommer>
Glauber Costa wrote:
>> This wasn't introduced by this patch, but the comparison is broken ion
>> i386 hosts, where target_phys_addr_t is 32 bits wide. mem->start_addr +
>> mem->memory_size can overflow (this in fact happens for the bios slot at
>> 4G-128K)
>>
> AFAIK, the assumption is that kvm will always be qemu-system-x86_64, due to
> migration issues.
That's an incorrect assumption. Users are free to build any qemu
variant they like. 32-bit qemu ought to work.
> Then, _target_ phys_addr_t is always 64 bit wide.
>
It is not. On a 32-bit host, qemu-system-x87_43's target_phys_addr_t is
32 bits wide.
> If it's not the case, then this is really a problem.
>
It isn't, so it is. I hacked around it in kvm-userspace.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org, stefano.stabellini@eu.citrix.com
Subject: [Qemu-devel] Re: [PATCH 5/5] cache slot lookup
Date: Thu, 18 Dec 2008 13:24:47 +0200 [thread overview]
Message-ID: <494A32FF.80103@redhat.com> (raw)
In-Reply-To: <20081218104850.GB19123@poweredge.glommer>
Glauber Costa wrote:
>> This wasn't introduced by this patch, but the comparison is broken ion
>> i386 hosts, where target_phys_addr_t is 32 bits wide. mem->start_addr +
>> mem->memory_size can overflow (this in fact happens for the bios slot at
>> 4G-128K)
>>
> AFAIK, the assumption is that kvm will always be qemu-system-x86_64, due to
> migration issues.
That's an incorrect assumption. Users are free to build any qemu
variant they like. 32-bit qemu ought to work.
> Then, _target_ phys_addr_t is always 64 bit wide.
>
It is not. On a 32-bit host, qemu-system-x87_43's target_phys_addr_t is
32 bits wide.
> If it's not the case, then this is really a problem.
>
It isn't, so it is. I hacked around it in kvm-userspace.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-12-18 11:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 20:46 [PATCH 0/5] Replace tcg memory functions Glauber Costa
2008-12-17 20:46 ` [Qemu-devel] " Glauber Costa
2008-12-17 20:46 ` [PATCH 1/5] re-register whole area upon lfb unmap Glauber Costa
2008-12-17 20:46 ` [Qemu-devel] " Glauber Costa
2008-12-17 20:46 ` [PATCH 2/5] isolate io handling routing Glauber Costa
2008-12-17 20:46 ` [Qemu-devel] " Glauber Costa
2008-12-17 20:47 ` [PATCH 3/5] replace cpu_physical_memory_rw Glauber Costa
2008-12-17 20:47 ` [Qemu-devel] " Glauber Costa
2008-12-17 20:47 ` [PATCH 4/5] hook cpu_register_physical_mem Glauber Costa
2008-12-17 20:47 ` [Qemu-devel] " Glauber Costa
2008-12-17 20:47 ` [PATCH 5/5] cache slot lookup Glauber Costa
2008-12-17 20:47 ` [Qemu-devel] " Glauber Costa
2008-12-18 9:41 ` Avi Kivity
2008-12-18 9:41 ` [Qemu-devel] " Avi Kivity
2008-12-18 10:48 ` Glauber Costa
2008-12-18 10:48 ` [Qemu-devel] " Glauber Costa
2008-12-18 11:00 ` Daniel P. Berrange
2008-12-18 11:00 ` Daniel P. Berrange
2008-12-18 11:07 ` Glauber Costa
2008-12-18 11:24 ` Avi Kivity [this message]
2008-12-18 11:24 ` Avi Kivity
2008-12-17 20:56 ` [PATCH 3/5] replace cpu_physical_memory_rw Anthony Liguori
2008-12-17 20:56 ` [Qemu-devel] " Anthony Liguori
2008-12-17 21:00 ` Glauber Costa
2008-12-17 21:00 ` [Qemu-devel] " Glauber Costa
2008-12-17 20:54 ` [PATCH 2/5] isolate io handling routing Anthony Liguori
2008-12-17 20:54 ` [Qemu-devel] " Anthony Liguori
2008-12-17 20:53 ` [PATCH 1/5] re-register whole area upon lfb unmap Anthony Liguori
2008-12-17 20:53 ` [Qemu-devel] " Anthony Liguori
2008-12-25 20:08 ` andrzej zaborowski
2008-12-25 20:08 ` andrzej zaborowski
2008-12-22 17:10 ` [Qemu-devel] [PATCH 0/5] Replace tcg memory functions Ian Jackson
2008-12-22 17:18 ` Glauber Costa
2008-12-22 17:18 ` Glauber Costa
2008-12-22 17:22 ` Ian Jackson
2008-12-22 17:22 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494A32FF.80103@redhat.com \
--to=avi@redhat.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.