From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Brown, Len" <len.brown@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
linux-acpi@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: state of some x86 acpi patches
Date: Thu, 18 Dec 2008 11:46:39 -0800 [thread overview]
Message-ID: <494AA89F.8020308@goop.org> (raw)
In-Reply-To: <874p111tta.fsf@basil.nowhere.org>
Andi Kleen wrote:
> Jeremy Fitzhardinge <jeremy@goop.org> writes:
>
>> However, unlike early_ioremap(), __acpi_map_table just maintains a
>> single mapping which gets replaced each call, and has no corresponding
>> unmap function. Implement this by just removing the previous mapping
>> each time its called. Unfortunately, this will leave a stray mapping
>> at the end.
>>
>
> Stray mappings are dangerous. They can lead to illegal cache aliases
> later. Better avoid them.
>
> I guess ACPI could call a cleanup function after it's done with
> all early mappings.
>
Right. But Yinghai (I think) went through and made all the acpi
mappings get properly mapped and unmapped, so my patch is moot.
J
next prev parent reply other threads:[~2008-12-18 19:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 19:19 state of some x86 acpi patches Jeremy Fitzhardinge
2008-12-16 19:25 ` Ingo Molnar
2008-12-31 23:38 ` Len Brown
2009-01-01 6:49 ` Jeremy Fitzhardinge
2009-01-02 15:39 ` Ingo Molnar
2009-01-02 22:28 ` Len Brown
2009-01-28 23:45 ` Jeremy Fitzhardinge
2009-01-29 1:10 ` Yinghai Lu
2009-02-07 2:58 ` Jeremy Fitzhardinge
2009-02-07 3:18 ` Yinghai Lu
2009-02-08 0:09 ` Jeremy Fitzhardinge
2009-02-09 12:37 ` Ingo Molnar
2009-02-15 19:36 ` Ingo Molnar
2009-02-15 22:06 ` Yinghai Lu
2009-02-15 22:25 ` Ingo Molnar
2009-02-15 22:46 ` Ingo Molnar
2009-02-15 23:10 ` Yinghai Lu
2009-02-20 21:54 ` Tony Luck
2009-02-20 21:55 ` Yinghai Lu
2008-12-18 13:44 ` Andi Kleen
2008-12-18 19:46 ` Jeremy Fitzhardinge [this message]
2008-12-18 21:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494AA89F.8020308@goop.org \
--to=jeremy@goop.org \
--cc=andi@firstfloor.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.