From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: state of some x86 acpi patches
Date: Sun, 15 Feb 2009 15:10:17 -0800 [thread overview]
Message-ID: <4998A0D9.9090303@kernel.org> (raw)
In-Reply-To: <20090215224607.GA2653@elte.hu>
Ingo Molnar wrote:
> hm, i still get:
>
> /home/mingo/tip/arch/ia64/kernel/acpi.c:203: error: conflicting types for '__acpi_unmap_table'
> /home/mingo/tip/include/linux/acpi.h:82: error: previous declaration of '__acpi_unmap_table' was here
> /home/mingo/tip/arch/ia64/kernel/acpi.c:203: error: conflicting types for '__acpi_unmap_table'
> /home/mingo/tip/include/linux/acpi.h:82: error: previous declaration of '__acpi_unmap_table' was here
>
sorry, please check this one
[PATCH] ia64: fix __apci_unmap_table -v2
Impact: fix wrong proto with compiling
to fix:
/home/mingo/tip/arch/ia64/kernel/acpi.c:203: error: conflicting types for '__acpi_unmap_table'
/home/mingo/tip/include/linux/acpi.h:82: error: previous declaration of '__acpi_unmap_table' was here
/home/mingo/tip/arch/ia64/kernel/acpi.c:203: error: conflicting types for '__acpi_unmap_table'
/home/mingo/tip/include/linux/acpi.h:82: error: previous declaration of '__acpi_unmap_table' was here
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/ia64/kernel/acpi.c | 2 +-
include/linux/acpi.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/arch/ia64/kernel/acpi.c
===================================================================
--- linux-2.6.orig/arch/ia64/kernel/acpi.c
+++ linux-2.6/arch/ia64/kernel/acpi.c
@@ -199,7 +199,7 @@ char *__init __acpi_map_table(unsigned l
return __va(phys_addr);
}
-char *__init __acpi_unmap_table(unsigned long virt_addr, unsigned long size)
+void __init __acpi_unmap_table(char *map, unsigned long size)
{
}
Index: linux-2.6/include/linux/acpi.h
===================================================================
--- linux-2.6.orig/include/linux/acpi.h
+++ linux-2.6/include/linux/acpi.h
@@ -79,7 +79,7 @@ typedef int (*acpi_table_handler) (struc
typedef int (*acpi_table_entry_handler) (struct acpi_subtable_header *header, const unsigned long end);
char * __acpi_map_table (unsigned long phys_addr, unsigned long size);
-void __init __acpi_unmap_table(char *map, unsigned long size);
+void __acpi_unmap_table(char *map, unsigned long size);
int early_acpi_boot_init(void);
int acpi_boot_init (void);
int acpi_boot_table_init (void);
next prev parent reply other threads:[~2009-02-15 23:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 19:19 state of some x86 acpi patches Jeremy Fitzhardinge
2008-12-16 19:25 ` Ingo Molnar
2008-12-31 23:38 ` Len Brown
2009-01-01 6:49 ` Jeremy Fitzhardinge
2009-01-02 15:39 ` Ingo Molnar
2009-01-02 22:28 ` Len Brown
2009-01-28 23:45 ` Jeremy Fitzhardinge
2009-01-29 1:10 ` Yinghai Lu
2009-02-07 2:58 ` Jeremy Fitzhardinge
2009-02-07 3:18 ` Yinghai Lu
2009-02-08 0:09 ` Jeremy Fitzhardinge
2009-02-09 12:37 ` Ingo Molnar
2009-02-15 19:36 ` Ingo Molnar
2009-02-15 22:06 ` Yinghai Lu
2009-02-15 22:25 ` Ingo Molnar
2009-02-15 22:46 ` Ingo Molnar
2009-02-15 23:10 ` Yinghai Lu [this message]
2009-02-20 21:54 ` Tony Luck
2009-02-20 21:55 ` Yinghai Lu
2008-12-18 13:44 ` Andi Kleen
2008-12-18 19:46 ` Jeremy Fitzhardinge
2008-12-18 21:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4998A0D9.9090303@kernel.org \
--to=yinghai@kernel.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.