From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] ide: remove 'byte' typedef
Date: Fri, 19 Dec 2008 14:54:33 +0300 [thread overview]
Message-ID: <494B8B79.4090805@ru.mvista.com> (raw)
In-Reply-To: <20081216193210.3959.92852.sendpatchset@localhost.localdomain>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Just use u8 instead, also s/__u8/u8/ in ide-cd.h while at it.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/qd65xx.h
> ===================================================================
> --- a/drivers/ide/qd65xx.h
> +++ b/drivers/ide/qd65xx.h
> @@ -31,8 +31,8 @@
>
> #define QD_CONFIG(hwif) ((hwif)->config_data & 0x00ff)
>
> -#define QD_TIMING(drive) (byte)(((drive)->drive_data) & 0x00ff)
> -#define QD_TIMREG(drive) (byte)((((drive)->drive_data) & 0xff00) >> 8)
> +#define QD_TIMING(drive) (u8)(((drive)->drive_data) & 0x00ff)
> +#define QD_TIMREG(drive) (u8)((((drive)->drive_data) & 0xff00) >> 8)
>
Could you drop the pointless parens around (drive)->drive_data, while
at it?
MBR, Sergei
next prev parent reply other threads:[~2008-12-19 11:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 19:31 [PATCH 1/9] ide: update ide_unregister() documentation Bartlomiej Zolnierkiewicz
2008-12-16 19:31 ` [PATCH 2/9] ide: move ide_init_port_data() and friends to ide-probe.c Bartlomiej Zolnierkiewicz
2008-12-16 19:31 ` [PATCH 3/9] ide: remove HWIF() macro Bartlomiej Zolnierkiewicz
2008-12-16 19:31 ` [PATCH 4/9] ide: remove local_irq_set() macro Bartlomiej Zolnierkiewicz
2008-12-16 19:32 ` [PATCH 5/9] ide: remove ide_pci_enablebit_t typedef Bartlomiej Zolnierkiewicz
2008-12-19 11:58 ` Sergei Shtylyov
2008-12-16 19:32 ` [PATCH 6/9] ide: remove 'byte' typedef Bartlomiej Zolnierkiewicz
2008-12-19 11:54 ` Sergei Shtylyov [this message]
2008-12-16 19:32 ` [PATCH 7/9] ide: remove ide_driver_t typedef Bartlomiej Zolnierkiewicz
2008-12-16 19:32 ` [PATCH 8/9] ide: unexport ide_wait_not_busy() Bartlomiej Zolnierkiewicz
2008-12-16 19:32 ` [PATCH 9/9] ide: remove ->error method from struct ide_driver Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494B8B79.4090805@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.