Re: Mesh now completely broken on ath5k, latest git

[Steve Brown <sbrown@cortland.com>]

Bob Copeland wrote:
> On Thu, Dec 18, 2008 at 4:02 PM, Steve Brown <sbrown@cortland.com> wrote:
>   
>> Lots of these however:
>> Dec 18 15:53:20 fl-ws kernel: ath5k phy23: beacon queue 7 didn't stop?
>>     
>
> Can you change the if statement that prints that in ath5k_beacon_send() in
> base.c to capture the return value?  i.e.:
>
> int err;
> ...
>
> err = ath5k_hw_stop_tx_dma(ah, sc->bhalq);
> if (unlikely(err)) {
>     ATH5K_WARN(... "...didn't stop? %d\n", sc->bhalq, err);
> }
>
>   
>> If I make the same change to the current git, still no beacons. But, the
>> "queue 7" msgs persist.
>>     
>
> Not sure, I was about to blame ath5k_configure_filter() but I see it does
> turn on the beacons for mesh.
>
>   
If I revert this part of the pcu patch, the "queue 7" messages go away. 
Beacons remain.

-       ath5k_hw_reg_write(ah, next_beacon, AR5K_TIMER0);
+       /* When in AP mode zero timer0 to start TSF */
+       if (ah->ah_op_mode == NL80211_IFTYPE_AP)
+               ath5k_hw_reg_write(ah, 0, AR5K_TIMER0);
+       else
+               ath5k_hw_reg_write(ah, next_beacon, AR5K_TIMER0);

The corresponding snippet of hal code seems to be:

        case HAL_M_HOSTAP:
                if (AH_PRIVATE(ah)->ah_opmode == HAL_M_HOSTAP)
                        OS_REG_WRITE(ah, AR_TIMER0, 0);
                else
                        OS_REG_WRITE(ah, AR_TIMER0, next_beacon);

No idea what's going on.

Steve