[PATCH] hda: fix incorrect mixer index values for 92hd83xx

[PATCH] hda: fix incorrect mixer index values for 92hd83xx

[Matthew Ranostay]

Fixed incorrect mixer index values for 92hd83xx codec's audio
input mixer.

Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
---

diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
index 70181d5..efa1fb0 100644
--- a/pci/hda/patch_sigmatel.c
+++ b/pci/hda/patch_sigmatel.c
@@ -1101,21 +1101,21 @@ static struct snd_kcontrol_new stac92hd83xxx_mixer[] = {
 	HDA_CODEC_VOLUME_IDX("Capture Volume", 0x1, 0x18, 0x0, HDA_OUTPUT),
 	HDA_CODEC_MUTE_IDX("Capture Switch", 0x1, 0x18, 0x0, HDA_OUTPUT),
 
-	HDA_CODEC_VOLUME("DAC0 Capture Volume", 0x1b, 0, HDA_INPUT),
-	HDA_CODEC_MUTE("DAC0 Capture Switch", 0x1b, 0, HDA_INPUT),
+	HDA_CODEC_VOLUME("DAC0 Capture Volume", 0x1b, 0x3, HDA_INPUT),
+	HDA_CODEC_MUTE("DAC0 Capture Switch", 0x1b, 0x3, HDA_INPUT),
 
-	HDA_CODEC_VOLUME("DAC1 Capture Volume", 0x1b, 0x1, HDA_INPUT),
-	HDA_CODEC_MUTE("DAC1 Capture Switch", 0x1b, 0x1, HDA_INPUT),
+	HDA_CODEC_VOLUME("DAC1 Capture Volume", 0x1b, 0x4, HDA_INPUT),
+	HDA_CODEC_MUTE("DAC1 Capture Switch", 0x1b, 0x4, HDA_INPUT),
 
-	HDA_CODEC_VOLUME("Front Mic Capture Volume", 0x1b, 0x2, HDA_INPUT),
-	HDA_CODEC_MUTE("Front Mic Capture Switch", 0x1b, 0x2, HDA_INPUT),
+	HDA_CODEC_VOLUME("Front Mic Capture Volume", 0x1b, 0x0, HDA_INPUT),
+	HDA_CODEC_MUTE("Front Mic Capture Switch", 0x1b, 0x0, HDA_INPUT),
 
-	HDA_CODEC_VOLUME("Line In Capture Volume", 0x1b, 0x3, HDA_INPUT),
-	HDA_CODEC_MUTE("Line In Capture Switch", 0x1b, 0x3, HDA_INPUT),
+	HDA_CODEC_VOLUME("Line In Capture Volume", 0x1b, 0x2, HDA_INPUT),
+	HDA_CODEC_MUTE("Line In Capture Switch", 0x1b, 0x2, HDA_INPUT),
 
 	/*
-	HDA_CODEC_VOLUME("Mic Capture Volume", 0x1b, 0x4, HDA_INPUT),
-	HDA_CODEC_MUTE("Mic Capture Switch", 0x1b 0x4, HDA_INPUT),
+	HDA_CODEC_VOLUME("Mic Capture Volume", 0x1b, 0x1, HDA_INPUT),
+	HDA_CODEC_MUTE("Mic Capture Switch", 0x1b 0x1, HDA_INPUT),
 	*/
 	{ } /* end */
 };

Re: [PATCH] hda: fix incorrect mixer index values for 92hd83xx

[Takashi Iwai]

At Sat, 20 Dec 2008 17:47:24 -0500,
Matthew Ranostay wrote:
> 
> Fixed incorrect mixer index values for 92hd83xx codec's audio
> input mixer.
> 
> Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>

Applied this one, too.

Regarding this change: what I've been concerned by the recent
patch_sigmatel.c are that the input routes are fixed, and capture
mixer elements are often too messy and not intuitive.

Hopefully we can sort out these later...


Thanks,

Takashi

Re: [PATCH] hda: fix incorrect mixer index values for 92hd83xx

[Matthew Ranostay]

Takashi Iwai wrote:
> At Sat, 20 Dec 2008 17:47:24 -0500,
> Matthew Ranostay wrote:
>> Fixed incorrect mixer index values for 92hd83xx codec's audio
>> input mixer.
>>
>> Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
> 
> Applied this one, too.
> 
> Regarding this change: what I've been concerned by the recent
> patch_sigmatel.c are that the input routes are fixed, and capture
> mixer elements are often too messy and not intuitive.
> 
Yeah, there has to be better way to do this.

> Hopefully we can sort out these later...
> 
> 
> Thanks,
> 
> Takashi
>