diff for duplicates of <494E7329.2090309@sandeen.net> diff --git a/a/1.txt b/N1/1.txt index 4a322e4..a23b45f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,11 +14,11 @@ Julia Lawall wrote: > position p1,p2; > @@ > -> if (x@p1 = NULL || ...) { ... when forall +> if (x@p1 == NULL || ...) { ... when forall > return ...; } > ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) > ( -> x@p2 = NULL +> x@p2 == NULL > | > x@p2 != NULL > ) @@ -31,7 +31,7 @@ Julia Lawall wrote: > > ... when != x@p1 > ( -> x@p2 = NULL +> x@p2 == NULL > | > x@p2 != NULL > ) @@ -46,9 +46,9 @@ Julia Lawall wrote: > - if ((x@p2 != NULL) || ...) > S1 > | -> - if ((x@p2 = NULL) && ...) S1 +> - if ((x@p2 == NULL) && ...) S1 > | -> - BUG_ON(x@p2 = NULL); +> - BUG_ON(x@p2 == NULL); > ) > // </smpl> > @@ -81,7 +81,12 @@ Reviewed-by: Eric Sandeen <sandeen@sandeen.net> > #ifdef DEBUG > - if (xfs_do_error && (bp != NULL)) { > + if (xfs_do_error) { -> if (xfs_error_target = target) { -> if (((xfs_req_num++) % xfs_error_mod) = 0) { +> if (xfs_error_target == target) { +> if (((xfs_req_num++) % xfs_error_mod) == 0) { > xfs_buf_relse(bp); -> +> + +_______________________________________________ +xfs mailing list +xfs@oss.sgi.com +http://oss.sgi.com/mailman/listinfo/xfs diff --git a/a/content_digest b/N1/content_digest index 2ded608..23c0baf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0Pine.LNX.4.64.0812211737180.9555@pc-004.diku.dk\0" "From\0Eric Sandeen <sandeen@sandeen.net>\0" "Subject\0Re: [PATCH 9/13] fs/xfs: Remove redundant test\0" - "Date\0Sun, 21 Dec 2008 16:47:37 +0000\0" + "Date\0Sun, 21 Dec 2008 10:47:37 -0600\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0xfs-masters@oss.sgi.com" kernel-janitors@vger.kernel.org @@ -27,11 +27,11 @@ "> position p1,p2;\n" "> @@\n" "> \n" - "> if (x@p1 = NULL || ...) { ... when forall\n" + "> if (x@p1 == NULL || ...) { ... when forall\n" "> return ...; }\n" "> ... when != \\(x=E\\|x--\\|x++\\|--x\\|++x\\|x-=E\\|x+=E\\|x|=E\\|x&=E\\|&x\\)\n" "> (\n" - "> x@p2 = NULL\n" + "> x@p2 == NULL\n" "> |\n" "> x@p2 != NULL\n" "> )\n" @@ -44,7 +44,7 @@ "> \n" "> ... when != x@p1\n" "> (\n" - "> x@p2 = NULL\n" + "> x@p2 == NULL\n" "> |\n" "> x@p2 != NULL\n" "> )\n" @@ -59,9 +59,9 @@ "> - if ((x@p2 != NULL) || ...)\n" "> S1\n" "> |\n" - "> - if ((x@p2 = NULL) && ...) S1\n" + "> - if ((x@p2 == NULL) && ...) S1\n" "> |\n" - "> - BUG_ON(x@p2 = NULL);\n" + "> - BUG_ON(x@p2 == NULL);\n" "> )\n" "> // </smpl>\n" "> \n" @@ -94,9 +94,14 @@ "> #ifdef DEBUG\n" "> -\t\tif (xfs_do_error && (bp != NULL)) {\n" "> +\t\tif (xfs_do_error) {\n" - "> \t\t\tif (xfs_error_target = target) {\n" - "> \t\t\t\tif (((xfs_req_num++) % xfs_error_mod) = 0) {\n" + "> \t\t\tif (xfs_error_target == target) {\n" + "> \t\t\t\tif (((xfs_req_num++) % xfs_error_mod) == 0) {\n" "> \t\t\t\t\txfs_buf_relse(bp);\n" - > + "> \n" + "\n" + "_______________________________________________\n" + "xfs mailing list\n" + "xfs@oss.sgi.com\n" + http://oss.sgi.com/mailman/listinfo/xfs -4f1f141583f67fa58c7ca56f027e1e5710f363a1d05b2581c0032d9b9ed8244e +17f4ae07f8e8ef9a118b4979b44be022029fd08466db216c7760ffc7eb5fcd90
diff --git a/a/1.txt b/N2/1.txt index 4a322e4..4a8ee2e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -14,11 +14,11 @@ Julia Lawall wrote: > position p1,p2; > @@ > -> if (x@p1 = NULL || ...) { ... when forall +> if (x@p1 == NULL || ...) { ... when forall > return ...; } > ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) > ( -> x@p2 = NULL +> x@p2 == NULL > | > x@p2 != NULL > ) @@ -31,7 +31,7 @@ Julia Lawall wrote: > > ... when != x@p1 > ( -> x@p2 = NULL +> x@p2 == NULL > | > x@p2 != NULL > ) @@ -46,9 +46,9 @@ Julia Lawall wrote: > - if ((x@p2 != NULL) || ...) > S1 > | -> - if ((x@p2 = NULL) && ...) S1 +> - if ((x@p2 == NULL) && ...) S1 > | -> - BUG_ON(x@p2 = NULL); +> - BUG_ON(x@p2 == NULL); > ) > // </smpl> > @@ -81,7 +81,7 @@ Reviewed-by: Eric Sandeen <sandeen@sandeen.net> > #ifdef DEBUG > - if (xfs_do_error && (bp != NULL)) { > + if (xfs_do_error) { -> if (xfs_error_target = target) { -> if (((xfs_req_num++) % xfs_error_mod) = 0) { +> if (xfs_error_target == target) { +> if (((xfs_req_num++) % xfs_error_mod) == 0) { > xfs_buf_relse(bp); > diff --git a/a/content_digest b/N2/content_digest index 2ded608..280778a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,12 +3,12 @@ "ref\0Pine.LNX.4.64.0812211737180.9555@pc-004.diku.dk\0" "From\0Eric Sandeen <sandeen@sandeen.net>\0" "Subject\0Re: [PATCH 9/13] fs/xfs: Remove redundant test\0" - "Date\0Sun, 21 Dec 2008 16:47:37 +0000\0" + "Date\0Sun, 21 Dec 2008 10:47:37 -0600\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0xfs-masters@oss.sgi.com" - kernel-janitors@vger.kernel.org + xfs@oss.sgi.com linux-kernel@vger.kernel.org - " xfs@oss.sgi.com\0" + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "Julia Lawall wrote:\n" @@ -27,11 +27,11 @@ "> position p1,p2;\n" "> @@\n" "> \n" - "> if (x@p1 = NULL || ...) { ... when forall\n" + "> if (x@p1 == NULL || ...) { ... when forall\n" "> return ...; }\n" "> ... when != \\(x=E\\|x--\\|x++\\|--x\\|++x\\|x-=E\\|x+=E\\|x|=E\\|x&=E\\|&x\\)\n" "> (\n" - "> x@p2 = NULL\n" + "> x@p2 == NULL\n" "> |\n" "> x@p2 != NULL\n" "> )\n" @@ -44,7 +44,7 @@ "> \n" "> ... when != x@p1\n" "> (\n" - "> x@p2 = NULL\n" + "> x@p2 == NULL\n" "> |\n" "> x@p2 != NULL\n" "> )\n" @@ -59,9 +59,9 @@ "> - if ((x@p2 != NULL) || ...)\n" "> S1\n" "> |\n" - "> - if ((x@p2 = NULL) && ...) S1\n" + "> - if ((x@p2 == NULL) && ...) S1\n" "> |\n" - "> - BUG_ON(x@p2 = NULL);\n" + "> - BUG_ON(x@p2 == NULL);\n" "> )\n" "> // </smpl>\n" "> \n" @@ -94,9 +94,9 @@ "> #ifdef DEBUG\n" "> -\t\tif (xfs_do_error && (bp != NULL)) {\n" "> +\t\tif (xfs_do_error) {\n" - "> \t\t\tif (xfs_error_target = target) {\n" - "> \t\t\t\tif (((xfs_req_num++) % xfs_error_mod) = 0) {\n" + "> \t\t\tif (xfs_error_target == target) {\n" + "> \t\t\t\tif (((xfs_req_num++) % xfs_error_mod) == 0) {\n" "> \t\t\t\t\txfs_buf_relse(bp);\n" > -4f1f141583f67fa58c7ca56f027e1e5710f363a1d05b2581c0032d9b9ed8244e +7c80afd6124c0eb58ba9da1e8b955342b6964eba3c7bd940a568af0900aca648
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.