All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, keescook@google.com,
	leozwang@google.com, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND RFC PATCH 2/2] ARM: dts: rockchip: Update the cpu freqs table
Date: Fri, 08 Jan 2016 20:16:19 +0100	[thread overview]
Message-ID: <4951150.PYM4FhWu6V@phil> (raw)
In-Reply-To: <1452252698-16765-3-git-send-email-zhengxing@rock-chips.com>

Hi Xing,

Am Freitag, 8. Januar 2016, 19:31:38 schrieb Xing Zheng:
> Actually, we need more cpu freqs which are 50MHz integer multiples.
> 
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
> 
>  arch/arm/boot/dts/rk3036.dtsi |   13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
> index 1cb5877..1a773eb 100644
> --- a/arch/arm/boot/dts/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rk3036.dtsi
> @@ -79,7 +79,18 @@
>  			resets = <&cru SRST_CORE0>;
>  			operating-points = <
>  				/* KHz    uV */
> -				 816000 1000000
> +				1200000 1200000
> +				1100000 1200000
> +				1000000 1200000
> +				 900000 1200000
> +				 800000 1200000
> +				 700000 1200000
> +				 600000 1200000
> +				 500000 1200000
> +				 400000 1200000
> +				 300000 1200000
> +				 200000 1200000
> +				 100000 1200000

what about reducing the voltage as well?

From rk3288-specific discussions I remember that reducing the frequency 
without touching the voltage, didn't really save so much energy.
And it looks like it was running 816MHz@1.0V just fine as well.

I guess you should find out which voltages are really necessary for each 
step.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND RFC PATCH 2/2] ARM: dts: rockchip: Update the cpu freqs table
Date: Fri, 08 Jan 2016 20:16:19 +0100	[thread overview]
Message-ID: <4951150.PYM4FhWu6V@phil> (raw)
In-Reply-To: <1452252698-16765-3-git-send-email-zhengxing@rock-chips.com>

Hi Xing,

Am Freitag, 8. Januar 2016, 19:31:38 schrieb Xing Zheng:
> Actually, we need more cpu freqs which are 50MHz integer multiples.
> 
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
> 
>  arch/arm/boot/dts/rk3036.dtsi |   13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
> index 1cb5877..1a773eb 100644
> --- a/arch/arm/boot/dts/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rk3036.dtsi
> @@ -79,7 +79,18 @@
>  			resets = <&cru SRST_CORE0>;
>  			operating-points = <
>  				/* KHz    uV */
> -				 816000 1000000
> +				1200000 1200000
> +				1100000 1200000
> +				1000000 1200000
> +				 900000 1200000
> +				 800000 1200000
> +				 700000 1200000
> +				 600000 1200000
> +				 500000 1200000
> +				 400000 1200000
> +				 300000 1200000
> +				 200000 1200000
> +				 100000 1200000

what about reducing the voltage as well?

>From rk3288-specific discussions I remember that reducing the frequency 
without touching the voltage, didn't really save so much energy.
And it looks like it was running 816MHz at 1.0V just fine as well.

I guess you should find out which voltages are really necessary for each 
step.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, keescook@google.com,
	leozwang@google.com, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND RFC PATCH 2/2] ARM: dts: rockchip: Update the cpu freqs table
Date: Fri, 08 Jan 2016 20:16:19 +0100	[thread overview]
Message-ID: <4951150.PYM4FhWu6V@phil> (raw)
In-Reply-To: <1452252698-16765-3-git-send-email-zhengxing@rock-chips.com>

Hi Xing,

Am Freitag, 8. Januar 2016, 19:31:38 schrieb Xing Zheng:
> Actually, we need more cpu freqs which are 50MHz integer multiples.
> 
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
> 
>  arch/arm/boot/dts/rk3036.dtsi |   13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
> index 1cb5877..1a773eb 100644
> --- a/arch/arm/boot/dts/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rk3036.dtsi
> @@ -79,7 +79,18 @@
>  			resets = <&cru SRST_CORE0>;
>  			operating-points = <
>  				/* KHz    uV */
> -				 816000 1000000
> +				1200000 1200000
> +				1100000 1200000
> +				1000000 1200000
> +				 900000 1200000
> +				 800000 1200000
> +				 700000 1200000
> +				 600000 1200000
> +				 500000 1200000
> +				 400000 1200000
> +				 300000 1200000
> +				 200000 1200000
> +				 100000 1200000

what about reducing the voltage as well?

>From rk3288-specific discussions I remember that reducing the frequency 
without touching the voltage, didn't really save so much energy.
And it looks like it was running 816MHz@1.0V just fine as well.

I guess you should find out which voltages are really necessary for each 
step.


Heiko

  reply	other threads:[~2016-01-08 19:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 11:31 [RESEND RFC PATCH 0/2] Add 100MHz integer multiples of cpu freq table for the RK3036 Xing Zheng
2016-01-08 11:31 ` Xing Zheng
2016-01-08 11:31 ` Xing Zheng
2016-01-08 11:31 ` [RESEND RFC PATCH 1/2] clk: rockchip: rk3036: Add to 100MHz integer multiples of cpu freq table Xing Zheng
2016-01-08 11:31   ` Xing Zheng
2016-01-08 11:31 ` [RESEND RFC PATCH 2/2] ARM: dts: rockchip: Update the cpu freqs table Xing Zheng
2016-01-08 11:31   ` Xing Zheng
2016-01-08 19:16   ` Heiko Stuebner [this message]
2016-01-08 19:16     ` Heiko Stuebner
2016-01-08 19:16     ` Heiko Stuebner
2016-01-09  3:04     ` Xing Zheng
2016-01-09  3:04       ` Xing Zheng
2016-01-09  3:04       ` Xing Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4951150.PYM4FhWu6V@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=keescook@google.com \
    --cc=leozwang@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=zhengxing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.