From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, yjwei@cn.fujitsu.com
Subject: Re: [PATCH net-next 1/5] sctp: Bring SCTP_MAXSEG socket option into
Date: Fri, 26 Dec 2008 17:04:14 +0000 [thread overview]
Message-ID: <49550E8E.6030607@hp.com> (raw)
In-Reply-To: <20081225.165625.248148862.davem@davemloft.net>
David Miller wrote:
> From: Vlad Yasevich <vladislav.yasevich@hp.com>
> Date: Fri, 19 Dec 2008 20:47:48 -0500
>
>> From: Wei Yongjun <yjwei@cn.fujitsu.com>
>>
>> Brings maxseg socket option set/get into line with the latest ietf socket
>> extensions API draft, while maintaining backwards compatibility.
>>
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>
> Applied. But I really dislike this scheme used by the compat code.
> Half-way initializing a structure and then depending upon the logic in
> the rest of the function to make sure the rest of the struct (the
> uninitialized part) is never accessed?
>
> Give me a break, programming, auditing, and bug fixing is hard enough
> as it is without sloppy code like this.
Yes, it sucks but the since the draft keeps breaking the ABI between revisions,
it leaves us a between a rock (no support) and a hard place (crappy code).
-vlad
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, yjwei@cn.fujitsu.com
Subject: Re: [PATCH net-next 1/5] sctp: Bring SCTP_MAXSEG socket option into ietf API extension compliance
Date: Fri, 26 Dec 2008 12:04:14 -0500 [thread overview]
Message-ID: <49550E8E.6030607@hp.com> (raw)
In-Reply-To: <20081225.165625.248148862.davem@davemloft.net>
David Miller wrote:
> From: Vlad Yasevich <vladislav.yasevich@hp.com>
> Date: Fri, 19 Dec 2008 20:47:48 -0500
>
>> From: Wei Yongjun <yjwei@cn.fujitsu.com>
>>
>> Brings maxseg socket option set/get into line with the latest ietf socket
>> extensions API draft, while maintaining backwards compatibility.
>>
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>
> Applied. But I really dislike this scheme used by the compat code.
> Half-way initializing a structure and then depending upon the logic in
> the rest of the function to make sure the rest of the struct (the
> uninitialized part) is never accessed?
>
> Give me a break, programming, auditing, and bug fixing is hard enough
> as it is without sloppy code like this.
Yes, it sucks but the since the draft keeps breaking the ABI between revisions,
it leaves us a between a rock (no support) and a hard place (crappy code).
-vlad
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-12-26 17:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-20 1:47 [PATCH net-next 0/5]: SCTP updates Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-20 1:47 ` [PATCH net-next 1/5] sctp: Bring SCTP_MAXSEG socket option into ietf API extension compliance Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-26 0:56 ` [PATCH net-next 1/5] sctp: Bring SCTP_MAXSEG socket option David Miller
2008-12-26 0:56 ` [PATCH net-next 1/5] sctp: Bring SCTP_MAXSEG socket option into ietf API extension compliance David Miller
2008-12-26 17:04 ` Vlad Yasevich [this message]
2008-12-26 17:04 ` Vlad Yasevich
2008-12-26 19:15 ` [PATCH net-next 1/5] sctp: Bring SCTP_MAXSEG socket option David Miller
2008-12-26 19:15 ` [PATCH net-next 1/5] sctp: Bring SCTP_MAXSEG socket option into ietf API extension compliance David Miller
2008-12-20 1:47 ` [PATCH net-next 2/5] sctp: Fix a typo in socket.c Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-26 0:57 ` David Miller
2008-12-26 0:57 ` David Miller
2008-12-20 1:47 ` [PATCH net-next 3/5] sctp: Implement socket option SCTP_GET_ASSOC_NUMBER Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-26 0:57 ` [PATCH net-next 3/5] sctp: Implement socket option David Miller
2008-12-26 0:57 ` [PATCH net-next 3/5] sctp: Implement socket option SCTP_GET_ASSOC_NUMBER David Miller
2008-12-20 1:47 ` [PATCH net-next 4/5] sctp: Avoid memory overflow while FWD-TSN chunk is received with bad stream ID Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-26 0:58 ` [PATCH net-next 4/5] sctp: Avoid memory overflow while FWD-TSN David Miller
2008-12-26 0:58 ` [PATCH net-next 4/5] sctp: Avoid memory overflow while FWD-TSN chunk is received with bad stream ID David Miller
2008-12-20 1:47 ` [PATCH net-next 5/5] sctp: Add validity check for SCTP_PARTIAL_DELIVERY_POINT socket option Vlad Yasevich
2008-12-20 1:47 ` Vlad Yasevich
2008-12-26 0:59 ` [PATCH net-next 5/5] sctp: Add validity check for David Miller
2008-12-26 0:59 ` [PATCH net-next 5/5] sctp: Add validity check for SCTP_PARTIAL_DELIVERY_POINT socket option David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49550E8E.6030607@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.