From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Mike Frysinger <vapier@gentoo.org>,
tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace
Date: Sat, 27 Dec 2008 13:15:29 -0800 [thread overview]
Message-ID: <49569AF1.8050205@zytor.com> (raw)
In-Reply-To: <20081227084708.GA16077@elte.hu>
Ingo Molnar wrote:
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
>> On Sat, Dec 27, 2008 at 01:50:04AM -0500, Mike Frysinger wrote:
>>> Use __asm__/__inline__ rather than asm/inline for all the functions
>>> exported to userspace.
>> I will imagine that we will see cleanup patches converting
>> these back to inline/asm.
>> How about doing this conversion as part of the headers_install.pl
>> script so we know it is always correct?
>>
>> Then we can keep the familiar inline/asm in the kernel headers
>> and always use the correct __asm__, __inline__ version for our
>> exported headers.
>
> or name it __asm__exported__ to make sure it isnt cleaned up away.
>
Seems better to do it automatically. We end up with cleaner-looking
code that way, too.
It doesn't solve the need for symbols in inline functions in exported
headers to have __ prefixes, though.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2008-12-27 21:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 6:50 [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace Mike Frysinger
2008-12-27 7:12 ` Sam Ravnborg
2008-12-27 7:55 ` Mike Frysinger
2008-12-27 8:47 ` Ingo Molnar
2008-12-27 9:21 ` Mike Frysinger
2008-12-27 18:57 ` Sam Ravnborg
2008-12-27 18:58 ` H. Peter Anvin
2008-12-27 19:12 ` Sam Ravnborg
2008-12-27 19:15 ` H. Peter Anvin
2008-12-27 19:21 ` Mike Frysinger
2008-12-27 19:23 ` H. Peter Anvin
2008-12-27 20:05 ` Mike Frysinger
2008-12-27 20:45 ` H. Peter Anvin
2008-12-27 20:57 ` Mike Frysinger
2008-12-27 21:08 ` H. Peter Anvin
2008-12-27 21:09 ` H. Peter Anvin
2008-12-29 11:56 ` Mike Frysinger
2008-12-29 17:44 ` H. Peter Anvin
2008-12-27 19:24 ` Sam Ravnborg
2008-12-27 19:24 ` H. Peter Anvin
2008-12-29 11:12 ` [PATCH] kbuild: auto-convert size types in userspace headers Mike Frysinger
2008-12-29 14:03 ` Sam Ravnborg
2008-12-29 20:34 ` Mike Frysinger
2008-12-29 20:36 ` H. Peter Anvin
2008-12-29 22:04 ` Mike Frysinger
2008-12-29 23:35 ` H. Peter Anvin
2008-12-30 10:43 ` Sam Ravnborg
2008-12-30 17:42 ` H. Peter Anvin
2009-01-18 20:53 ` Sam Ravnborg
2009-01-07 16:44 ` [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace David Woodhouse
2008-12-27 21:15 ` H. Peter Anvin [this message]
2008-12-28 22:35 ` Marcin Slusarz
2008-12-28 23:03 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49569AF1.8050205@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.