From: "H. Peter Anvin" <hpa@zytor.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: auto-convert size types in userspace headers
Date: Mon, 29 Dec 2008 12:36:41 -0800 [thread overview]
Message-ID: <495934D9.2070908@zytor.com> (raw)
In-Reply-To: <200812291534.49577.vapier@gentoo.org>
Mike Frysinger wrote:
> On Monday 29 December 2008 09:03:56 Sam Ravnborg wrote:
>> On Mon, Dec 29, 2008 at 06:12:33AM -0500, Mike Frysinger wrote:
>>> Rather than constantly fixing up size type breakage in userspace headers,
>>> auto convert the types u_intXX_t, uintXX_t, intXX_t, uXX, and sXX to the
>>> appropriate __uXX or __sXX type.
>> Is this the right thing to do?
>> uintXX_t belongs to a namespace that the kernel should not use.
>
> some headers are shared between projects and so use the uintXX_t form, so i'm
> not sure outright banning it is a nice answer for them
Arguably, the right answer is the opposite... the Linux u* and s* forms
feel much more like nonstandard legacy code to me. They have the
advantage of brevity, however.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2008-12-29 20:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 6:50 [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace Mike Frysinger
2008-12-27 7:12 ` Sam Ravnborg
2008-12-27 7:55 ` Mike Frysinger
2008-12-27 8:47 ` Ingo Molnar
2008-12-27 9:21 ` Mike Frysinger
2008-12-27 18:57 ` Sam Ravnborg
2008-12-27 18:58 ` H. Peter Anvin
2008-12-27 19:12 ` Sam Ravnborg
2008-12-27 19:15 ` H. Peter Anvin
2008-12-27 19:21 ` Mike Frysinger
2008-12-27 19:23 ` H. Peter Anvin
2008-12-27 20:05 ` Mike Frysinger
2008-12-27 20:45 ` H. Peter Anvin
2008-12-27 20:57 ` Mike Frysinger
2008-12-27 21:08 ` H. Peter Anvin
2008-12-27 21:09 ` H. Peter Anvin
2008-12-29 11:56 ` Mike Frysinger
2008-12-29 17:44 ` H. Peter Anvin
2008-12-27 19:24 ` Sam Ravnborg
2008-12-27 19:24 ` H. Peter Anvin
2008-12-29 11:12 ` [PATCH] kbuild: auto-convert size types in userspace headers Mike Frysinger
2008-12-29 14:03 ` Sam Ravnborg
2008-12-29 20:34 ` Mike Frysinger
2008-12-29 20:36 ` H. Peter Anvin [this message]
2008-12-29 22:04 ` Mike Frysinger
2008-12-29 23:35 ` H. Peter Anvin
2008-12-30 10:43 ` Sam Ravnborg
2008-12-30 17:42 ` H. Peter Anvin
2009-01-18 20:53 ` Sam Ravnborg
2009-01-07 16:44 ` [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace David Woodhouse
2008-12-27 21:15 ` H. Peter Anvin
2008-12-28 22:35 ` Marcin Slusarz
2008-12-28 23:03 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495934D9.2070908@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.