All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] arm/defconfigs: Remove CONFIG_IPV6_PRIVACY
Date: Thu, 11 Aug 2016 22:26:26 +0200	[thread overview]
Message-ID: <4958578.R1lMSWqhcA@wuerfel> (raw)
In-Reply-To: <20160811170035.GD7296@nazgul.tnic>

On Thursday, August 11, 2016 7:00:35 PM CEST Borislav Petkov wrote:
> On Wed, Apr 20, 2016 at 12:59:04PM +0300, Vladimir Zapolskiy wrote:
> > Probably you may do something similar for S3C24xx and send the change
> > to Samsung maintainers.
> 
> How does that look like?

I'd prefer not to do it mechanically, please check the things that
changed to see if they made sense.

> diff --git a/arch/arm/configs/s3c2410_defconfig b/arch/arm/configs/s3c2410_defconfig
> index b3ade552a2a5..7339d6f5d71b 100644
> --- a/arch/arm/configs/s3c2410_defconfig
> +++ b/arch/arm/configs/s3c2410_defconfig
> @@ -1,4 +1,3 @@
> -CONFIG_EXPERIMENTAL=y
>  CONFIG_SYSVIPC=y
>  CONFIG_IKCONFIG=m
>  CONFIG_IKCONFIG_PROC=y
> @@ -12,9 +11,6 @@ CONFIG_PARTITION_ADVANCED=y
>  CONFIG_BSD_DISKLABEL=y
>  CONFIG_SOLARIS_X86_PARTITION=y
>  CONFIG_ARCH_S3C24XX=y
> -CONFIG_S3C_BOOT_ERROR_RESET=y

The option is gone, that is fine.

> -CONFIG_S3C_ADC=y

This one moved around, better not mix that with the other changes.

> -CONFIG_S3C24XX_PWM=y

Two boards select this, and are apparently enabled by default.
Why? Could we remove the 'select' and leave this line?

> @@ -38,20 +34,18 @@ CONFIG_MACH_AT2440EVB=y
>  CONFIG_MACH_MINI2440=y
>  CONFIG_MACH_NEXCODER_2440=y
>  CONFIG_MACH_OSIRIS=y
> -CONFIG_MACH_OSIRIS_DVS=m

Why remove this? Is TPS65010 disabled now? Maybe its dependencies
need to be updated.


>  CONFIG_FPE_NWFPE=y
>  CONFIG_FPE_NWFPE_XP=y
> -CONFIG_BINFMT_AOUT=y
>  CONFIG_APM_EMULATION=m
>  CONFIG_NET=y
>  CONFIG_PACKET=y

This was removed in v3.11, but a lot of defconfigs still
try to enable it. Maybe do them all at once?

> @@ -67,7 +61,6 @@ CONFIG_NET_IPIP=m
>  CONFIG_INET_AH=m
>  CONFIG_INET_ESP=m
>  CONFIG_INET_IPCOMP=m
> -# CONFIG_INET_LRO is not set
>  CONFIG_TCP_CONG_ADVANCED=y
>  CONFIG_TCP_CONG_HSTCP=m
>  CONFIG_TCP_CONG_HYBLA=m

Same thing, removed in v4.6, but still referenced in 199 files.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Borislav Petkov <bp@alien8.de>, Vladimir Zapolskiy <vz@mleia.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] arm/defconfigs: Remove CONFIG_IPV6_PRIVACY
Date: Thu, 11 Aug 2016 22:26:26 +0200	[thread overview]
Message-ID: <4958578.R1lMSWqhcA@wuerfel> (raw)
In-Reply-To: <20160811170035.GD7296@nazgul.tnic>

On Thursday, August 11, 2016 7:00:35 PM CEST Borislav Petkov wrote:
> On Wed, Apr 20, 2016 at 12:59:04PM +0300, Vladimir Zapolskiy wrote:
> > Probably you may do something similar for S3C24xx and send the change
> > to Samsung maintainers.
> 
> How does that look like?

I'd prefer not to do it mechanically, please check the things that
changed to see if they made sense.

> diff --git a/arch/arm/configs/s3c2410_defconfig b/arch/arm/configs/s3c2410_defconfig
> index b3ade552a2a5..7339d6f5d71b 100644
> --- a/arch/arm/configs/s3c2410_defconfig
> +++ b/arch/arm/configs/s3c2410_defconfig
> @@ -1,4 +1,3 @@
> -CONFIG_EXPERIMENTAL=y
>  CONFIG_SYSVIPC=y
>  CONFIG_IKCONFIG=m
>  CONFIG_IKCONFIG_PROC=y
> @@ -12,9 +11,6 @@ CONFIG_PARTITION_ADVANCED=y
>  CONFIG_BSD_DISKLABEL=y
>  CONFIG_SOLARIS_X86_PARTITION=y
>  CONFIG_ARCH_S3C24XX=y
> -CONFIG_S3C_BOOT_ERROR_RESET=y

The option is gone, that is fine.

> -CONFIG_S3C_ADC=y

This one moved around, better not mix that with the other changes.

> -CONFIG_S3C24XX_PWM=y

Two boards select this, and are apparently enabled by default.
Why? Could we remove the 'select' and leave this line?

> @@ -38,20 +34,18 @@ CONFIG_MACH_AT2440EVB=y
>  CONFIG_MACH_MINI2440=y
>  CONFIG_MACH_NEXCODER_2440=y
>  CONFIG_MACH_OSIRIS=y
> -CONFIG_MACH_OSIRIS_DVS=m

Why remove this? Is TPS65010 disabled now? Maybe its dependencies
need to be updated.


>  CONFIG_FPE_NWFPE=y
>  CONFIG_FPE_NWFPE_XP=y
> -CONFIG_BINFMT_AOUT=y
>  CONFIG_APM_EMULATION=m
>  CONFIG_NET=y
>  CONFIG_PACKET=y

This was removed in v3.11, but a lot of defconfigs still
try to enable it. Maybe do them all at once?

> @@ -67,7 +61,6 @@ CONFIG_NET_IPIP=m
>  CONFIG_INET_AH=m
>  CONFIG_INET_ESP=m
>  CONFIG_INET_IPCOMP=m
> -# CONFIG_INET_LRO is not set
>  CONFIG_TCP_CONG_ADVANCED=y
>  CONFIG_TCP_CONG_HSTCP=m
>  CONFIG_TCP_CONG_HYBLA=m

Same thing, removed in v4.6, but still referenced in 199 files.

	Arnd

  reply	other threads:[~2016-08-11 20:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 11:42 [PATCH 0/5] Remove last remnants of CONFIG_IPV6_PRIVACY from arch defconfigs Borislav Petkov
2016-03-30 11:42 ` [PATCH 1/5] arm/defconfigs: Remove CONFIG_IPV6_PRIVACY Borislav Petkov
2016-03-30 11:42   ` Borislav Petkov
2016-04-20  9:59   ` Vladimir Zapolskiy
2016-04-20  9:59     ` Vladimir Zapolskiy
2016-08-11 17:00     ` Borislav Petkov
2016-08-11 17:00       ` Borislav Petkov
2016-08-11 20:26       ` Arnd Bergmann [this message]
2016-08-11 20:26         ` Arnd Bergmann
2016-08-11 21:35         ` Borislav Petkov
2016-08-11 21:35           ` Borislav Petkov
2016-08-11 21:51           ` Arnd Bergmann
2016-08-11 21:51             ` Arnd Bergmann
2016-08-12  5:22             ` Borislav Petkov
2016-08-12  5:22               ` Borislav Petkov
2016-08-12  6:19               ` Krzysztof Kozlowski
2016-08-12  6:19                 ` Krzysztof Kozlowski
2016-03-30 11:42 ` [PATCH 2/5] mips/defconfigs: " Borislav Petkov
2016-03-30 21:43   ` Ralf Baechle
2016-03-30 11:42 ` [PATCH 3/5] sh/defconfigs: " Borislav Petkov
2016-03-30 11:42   ` Borislav Petkov
2016-03-30 11:42 ` [PATCH 4/5] sparc/defconfigs: " Borislav Petkov
2016-03-30 11:42   ` Borislav Petkov
2016-04-27 20:38   ` David Miller
2016-04-27 20:38     ` David Miller
2016-03-30 11:42 ` [PATCH 5/5] tile/defconfigs: " Borislav Petkov
2016-03-30 15:23   ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4958578.R1lMSWqhcA@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.