All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Andy Chiu <andy.chiu@sifive.com>, <davem@davemloft.net>,
	<kuba@kernel.org>, <michal.simek@xilinx.com>,
	<radhey.shyam.pandey@xilinx.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
	<pabeni@redhat.com>, <edumazet@google.com>,
	<greentime.hu@sifive.com>
Subject: Re: [PATCH net-next 2/2] dt-bindings: add mdio frequency description
Date: Thu, 20 Oct 2022 12:39:46 +0200	[thread overview]
Message-ID: <495eb398-bec4-5d68-ef5d-4f02d0122a7c@amd.com> (raw)
In-Reply-To: <20221020094106.559266-3-andy.chiu@sifive.com>



On 10/20/22 11:41, Andy Chiu wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
> 
> 
> Add a property to set mdio bus frequency at runtime by DT.
> 
> Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
> Reviewed-by: Greentime Hu <greentime.hu@sifive.com>
> ---
>   Documentation/devicetree/bindings/net/xilinx_axienet.txt | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/xilinx_axienet.txt b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> index 1aa4c6006cd0..d78cf402aa2a 100644
> --- a/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> +++ b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> @@ -43,6 +43,9 @@ Optional properties:
>                    support both 1000BaseX and SGMII modes. If set, the phy-mode
>                    should be set to match the mode selected on core reset (i.e.
>                    by the basex_or_sgmii core input line).
> +- xlnx,mdio-freq: Define the clock frequency of the MDIO bus. If the property
> +                 does not pressent on the DT, then the mdio driver would use
> +                 the default 2.5 MHz clock, as mentioned on 802.3 spc.

Isn't it better to specify it based on ccf description. It means &clk and used 
clock framework to find value?

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@amd.com>
To: Andy Chiu <andy.chiu@sifive.com>, <davem@davemloft.net>,
	<kuba@kernel.org>, <michal.simek@xilinx.com>,
	<radhey.shyam.pandey@xilinx.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
	<pabeni@redhat.com>, <edumazet@google.com>,
	<greentime.hu@sifive.com>
Subject: Re: [PATCH net-next 2/2] dt-bindings: add mdio frequency description
Date: Thu, 20 Oct 2022 12:39:46 +0200	[thread overview]
Message-ID: <495eb398-bec4-5d68-ef5d-4f02d0122a7c@amd.com> (raw)
In-Reply-To: <20221020094106.559266-3-andy.chiu@sifive.com>



On 10/20/22 11:41, Andy Chiu wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
> 
> 
> Add a property to set mdio bus frequency at runtime by DT.
> 
> Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
> Reviewed-by: Greentime Hu <greentime.hu@sifive.com>
> ---
>   Documentation/devicetree/bindings/net/xilinx_axienet.txt | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/xilinx_axienet.txt b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> index 1aa4c6006cd0..d78cf402aa2a 100644
> --- a/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> +++ b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> @@ -43,6 +43,9 @@ Optional properties:
>                    support both 1000BaseX and SGMII modes. If set, the phy-mode
>                    should be set to match the mode selected on core reset (i.e.
>                    by the basex_or_sgmii core input line).
> +- xlnx,mdio-freq: Define the clock frequency of the MDIO bus. If the property
> +                 does not pressent on the DT, then the mdio driver would use
> +                 the default 2.5 MHz clock, as mentioned on 802.3 spc.

Isn't it better to specify it based on ccf description. It means &clk and used 
clock framework to find value?

Thanks,
Michal

  reply	other threads:[~2022-10-20 11:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  9:41 [PATCH net-next 0/2] net:axienet: Add a DT property to configure frequency of the MDIO bus Andy Chiu
2022-10-20  9:41 ` Andy Chiu
2022-10-20  9:41 ` [PATCH net-next 1/2] net:xilinx_axi: set mdio frequency according to DT Andy Chiu
2022-10-20  9:41   ` Andy Chiu
2022-10-20 11:35   ` Alexander Stein
2022-10-20 11:35     ` Alexander Stein
2022-10-20  9:41 ` [PATCH net-next 2/2] dt-bindings: add mdio frequency description Andy Chiu
2022-10-20  9:41   ` Andy Chiu
2022-10-20 10:39   ` Michal Simek [this message]
2022-10-20 10:39     ` Michal Simek
2022-10-21  2:20     ` Rob Herring
2022-10-21  2:20       ` Rob Herring
2022-10-23 15:04       ` Andy Chiu
2022-10-23 15:04         ` Andy Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495eb398-bec4-5d68-ef5d-4f02d0122a7c@amd.com \
    --to=michal.simek@amd.com \
    --cc=andy.chiu@sifive.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=greentime.hu@sifive.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.