* [PATCH] platform/x86: touchscreen_dmi: Add info for SARY Tab 3 tablet
@ 2024-12-02 22:18 buingoc67
2024-12-10 14:31 ` Ilpo Järvinen
0 siblings, 1 reply; 4+ messages in thread
From: buingoc67 @ 2024-12-02 22:18 UTC (permalink / raw)
To: platform-driver-x86; +Cc: hmtheboy154
From: hmtheboy154 <buingoc67@gmail.com>
There's no info about the OEM behind the tablet, only online stores
listing. This tablet uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB
of storage.
Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
---
drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 0a39f68c641d..bdc19cd8d3ed 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -855,6 +855,23 @@ static const struct ts_dmi_data rwc_nanote_next_data = {
.properties = rwc_nanote_next_props,
};
+static const struct property_entry sary_tab_3_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 1730),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 1151),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+ PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+ PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-sary-tab-3.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ PROPERTY_ENTRY_BOOL("silead,home-button"),
+ { }
+};
+
+static const struct ts_dmi_data sary_tab_3_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = sary_tab_3_props,
+};
+
static const struct property_entry schneider_sct101ctm_props[] = {
PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
@@ -1615,6 +1632,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
DMI_MATCH(DMI_BIOS_VERSION, "S8A70R100-V005"),
},
},
+ {
+ /* SARY Tab 3 */
+ .driver_data = (void *)&sary_tab_3_data,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SARY"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "C210C"),
+ DMI_MATCH(DMI_PRODUCT_SKU, "TAB3"),
+ },
+ },
{
/* Schneider SCT101CTM */
.driver_data = (void *)&schneider_sct101ctm_data,
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for SARY Tab 3 tablet
2024-12-02 22:18 [PATCH] platform/x86: touchscreen_dmi: Add info for SARY Tab 3 tablet buingoc67
@ 2024-12-10 14:31 ` Ilpo Järvinen
2024-12-10 15:04 ` Huy Minh
0 siblings, 1 reply; 4+ messages in thread
From: Ilpo Järvinen @ 2024-12-10 14:31 UTC (permalink / raw)
To: hmtheboy154; +Cc: platform-driver-x86
On Tue, 3 Dec 2024, buingoc67@gmail.com wrote:
> From: hmtheboy154 <buingoc67@gmail.com>
>
> There's no info about the OEM behind the tablet, only online stores
> listing. This tablet uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB
> of storage.
>
> Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
Hi,
Thank you for the patch.
We need to have your proper name in From and Signed-off-by tag before a
patch can be accepted. Please send a v2 with that fixed, thanks.
--
i.
> ---
> drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 0a39f68c641d..bdc19cd8d3ed 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -855,6 +855,23 @@ static const struct ts_dmi_data rwc_nanote_next_data = {
> .properties = rwc_nanote_next_props,
> };
>
> +static const struct property_entry sary_tab_3_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1730),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1151),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-sary-tab-3.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data sary_tab_3_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = sary_tab_3_props,
> +};
> +
> static const struct property_entry schneider_sct101ctm_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
> PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> @@ -1615,6 +1632,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_MATCH(DMI_BIOS_VERSION, "S8A70R100-V005"),
> },
> },
> + {
> + /* SARY Tab 3 */
> + .driver_data = (void *)&sary_tab_3_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "SARY"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "C210C"),
> + DMI_MATCH(DMI_PRODUCT_SKU, "TAB3"),
> + },
> + },
> {
> /* Schneider SCT101CTM */
> .driver_data = (void *)&schneider_sct101ctm_data,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for SARY Tab 3 tablet
2024-12-10 14:31 ` Ilpo Järvinen
@ 2024-12-10 15:04 ` Huy Minh
2024-12-11 14:20 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Huy Minh @ 2024-12-10 15:04 UTC (permalink / raw)
To: Ilpo Järvinen; +Cc: platform-driver-x86
On Tuesday, December 10, 2024 9:31:37 PM Indochina Time Ilpo Järvinen wrote:
> On Tue, 3 Dec 2024, buingoc67@gmail.com wrote:
> > From: hmtheboy154 <buingoc67@gmail.com>
> >
> > There's no info about the OEM behind the tablet, only online stores
> > listing. This tablet uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB
> > of storage.
> >
> > Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
>
> Hi,
>
> Thank you for the patch.
>
> We need to have your proper name in From and Signed-off-by tag before a
> patch can be accepted. Please send a v2 with that fixed, thanks.
>
> --
> i.
>
Thank you. I'll send a new patch. I thought I can keep this as I used to send
patches with the same name to Hans de Goede.
> > ---
> >
> > drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/platform/x86/touchscreen_dmi.c
> > b/drivers/platform/x86/touchscreen_dmi.c index 0a39f68c641d..bdc19cd8d3ed
> > 100644
> > --- a/drivers/platform/x86/touchscreen_dmi.c
> > +++ b/drivers/platform/x86/touchscreen_dmi.c
> > @@ -855,6 +855,23 @@ static const struct ts_dmi_data rwc_nanote_next_data
> > = {>
> > .properties = rwc_nanote_next_props,
> >
> > };
> >
> > +static const struct property_entry sary_tab_3_props[] = {
> > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1730),
> > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1151),
> > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> > + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> > + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-sary-tab-3.fw"),
> > + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> > + PROPERTY_ENTRY_BOOL("silead,home-button"),
> > + { }
> > +};
> > +
> > +static const struct ts_dmi_data sary_tab_3_data = {
> > + .acpi_name = "MSSL1680:00",
> > + .properties = sary_tab_3_props,
> > +};
> > +
> >
> > static const struct property_entry schneider_sct101ctm_props[] = {
> >
> > PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
> > PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> >
> > @@ -1615,6 +1632,15 @@ const struct dmi_system_id touchscreen_dmi_table[]
> > = {>
> > DMI_MATCH(DMI_BIOS_VERSION, "S8A70R100-
V005"),
> >
> > },
> >
> > },
> >
> > + {
> > + /* SARY Tab 3 */
> > + .driver_data = (void *)&sary_tab_3_data,
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "SARY"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "C210C"),
> > + DMI_MATCH(DMI_PRODUCT_SKU, "TAB3"),
> > + },
> > + },
> >
> > {
> >
> > /* Schneider SCT101CTM */
> > .driver_data = (void *)&schneider_sct101ctm_data,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for SARY Tab 3 tablet
2024-12-10 15:04 ` Huy Minh
@ 2024-12-11 14:20 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2024-12-11 14:20 UTC (permalink / raw)
To: Huy Minh, Ilpo Järvinen; +Cc: platform-driver-x86
Hi,
On 10-Dec-24 4:04 PM, Huy Minh wrote:
> On Tuesday, December 10, 2024 9:31:37 PM Indochina Time Ilpo Järvinen wrote:
>> On Tue, 3 Dec 2024, buingoc67@gmail.com wrote:
>>> From: hmtheboy154 <buingoc67@gmail.com>
>>>
>>> There's no info about the OEM behind the tablet, only online stores
>>> listing. This tablet uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB
>>> of storage.
>>>
>>> Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
>>
>> Hi,
>>
>> Thank you for the patch.
>>
>> We need to have your proper name in From and Signed-off-by tag before a
>> patch can be accepted. Please send a v2 with that fixed, thanks.
>>
>> --
>> i.
>>
>
> Thank you. I'll send a new patch. I thought I can keep this as I used to send
> patches with the same name to Hans de Goede.
To clarify this, a while ago there was a clarification of the:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
policy:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330
changing from requiring "using your real name" to "using a known identity".
Since Huy Minh also uses hmtheboy154 as e.g. github username (1) that counts
to me as a known identity. So I merged Huy Minh's contributions with
hmtheboy154 as author + S-o-b name based on that.
Regards,
Hans
1) See e.g. https://github.com/onitake/gsl-firmware/pull/242
>
>
>>> ---
>>>
>>> drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
>>> 1 file changed, 26 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/touchscreen_dmi.c
>>> b/drivers/platform/x86/touchscreen_dmi.c index 0a39f68c641d..bdc19cd8d3ed
>>> 100644
>>> --- a/drivers/platform/x86/touchscreen_dmi.c
>>> +++ b/drivers/platform/x86/touchscreen_dmi.c
>>> @@ -855,6 +855,23 @@ static const struct ts_dmi_data rwc_nanote_next_data
>>> = {>
>>> .properties = rwc_nanote_next_props,
>>>
>>> };
>>>
>>> +static const struct property_entry sary_tab_3_props[] = {
>>> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1730),
>>> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1151),
>>> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
>>> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
>>> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
>>> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-sary-tab-3.fw"),
>>> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
>>> + PROPERTY_ENTRY_BOOL("silead,home-button"),
>>> + { }
>>> +};
>>> +
>>> +static const struct ts_dmi_data sary_tab_3_data = {
>>> + .acpi_name = "MSSL1680:00",
>>> + .properties = sary_tab_3_props,
>>> +};
>>> +
>>>
>>> static const struct property_entry schneider_sct101ctm_props[] = {
>>>
>>> PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
>>> PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
>>>
>>> @@ -1615,6 +1632,15 @@ const struct dmi_system_id touchscreen_dmi_table[]
>>> = {>
>>> DMI_MATCH(DMI_BIOS_VERSION, "S8A70R100-
> V005"),
>>>
>>> },
>>>
>>> },
>>>
>>> + {
>>> + /* SARY Tab 3 */
>>> + .driver_data = (void *)&sary_tab_3_data,
>>> + .matches = {
>>> + DMI_MATCH(DMI_SYS_VENDOR, "SARY"),
>>> + DMI_MATCH(DMI_PRODUCT_NAME, "C210C"),
>>> + DMI_MATCH(DMI_PRODUCT_SKU, "TAB3"),
>>> + },
>>> + },
>>>
>>> {
>>>
>>> /* Schneider SCT101CTM */
>>> .driver_data = (void *)&schneider_sct101ctm_data,
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-11 14:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02 22:18 [PATCH] platform/x86: touchscreen_dmi: Add info for SARY Tab 3 tablet buingoc67
2024-12-10 14:31 ` Ilpo Järvinen
2024-12-10 15:04 ` Huy Minh
2024-12-11 14:20 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.