From: Gabor Juhos <juhosg@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC 08/12] ath9k: get EEPROM contents from platform data on AHB bus
Date: Mon, 05 Jan 2009 13:23:45 +0100 [thread overview]
Message-ID: <4961FBD1.4030103@openwrt.org> (raw)
In-Reply-To: <18785.57618.47120.669270@gargle.gargle.HOWL>
Sujith ?rta:
> Gabor Juhos wrote:
>> +#ifndef _LINUX_ATH9K_PLATFORM_H
>> +#define _LINUX_ATH9L_PLATFORM_H
>
> Typo ?
Oops, yes.
> Also, after addressing Christopher's comments, I don't think too many
> bus specific routines would remain. In that case would it be reasonable
> to just have a single file (bus.c, with appropriate ifdefs), instead
> of pci.c and ahb.c ?
We will have 3 of them actually (read_cachesize, read_eeprom, cleanup), but here
is the whole {pci,platform}_driver specific stuff. Of course we can move all of
this into one file, but i would like to avoid the unnecessary ifdefs where it is
possible. Apart from this, if we will put the PCI and AHB stuff into one file,
we could put it into main.c simply.
-Gabor
WARNING: multiple messages have this Message-ID (diff)
From: Gabor Juhos <juhosg@openwrt.org>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@atheros.com>,
Jouni Malinen <Jouni.Malinen@atheros.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>, Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [RFC 08/12] ath9k: get EEPROM contents from platform data on AHB bus
Date: Mon, 05 Jan 2009 13:23:45 +0100 [thread overview]
Message-ID: <4961FBD1.4030103@openwrt.org> (raw)
In-Reply-To: <18785.57618.47120.669270@gargle.gargle.HOWL>
Sujith =EDrta:
> Gabor Juhos wrote:
>> +#ifndef _LINUX_ATH9K_PLATFORM_H
>> +#define _LINUX_ATH9L_PLATFORM_H
>=20
> Typo ?
Oops, yes.
> Also, after addressing Christopher's comments, I don't think too many
> bus specific routines would remain. In that case would it be reasonab=
le
> to just have a single file (bus.c, with appropriate ifdefs), instead
> of pci.c and ahb.c ?
We will have 3 of them actually (read_cachesize, read_eeprom, cleanup),=
but here
is the whole {pci,platform}_driver specific stuff. Of course we can mov=
e all of
this into one file, but i would like to avoid the unnecessary ifdefs wh=
ere it is
possible. Apart from this, if we will put the PCI and AHB stuff into on=
e file,
we could put it into main.c simply.
-Gabor
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-05 12:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-03 13:44 [ath9k-devel] [RFC 00/12] ath9k: add preliminary support for the AR913x SoCs Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 01/12] ath9k: introduce bus specific DMA routines Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-04 7:26 ` [ath9k-devel] " Christoph Hellwig
2009-01-04 7:26 ` Christoph Hellwig
2009-01-04 11:16 ` [ath9k-devel] " Gabor Juhos
2009-01-04 11:16 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 02/12] ath9k: introduce bus specific register access routines Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-04 7:27 ` [ath9k-devel] " Christoph Hellwig
2009-01-04 7:27 ` Christoph Hellwig
2009-01-04 11:17 ` [ath9k-devel] " Gabor Juhos
2009-01-04 11:17 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 03/12] ath9k: introduce bus specific cache size routine Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 04/12] ath9k: introduce bus specific cleanup routine Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 05/12] ath9k: move PCI code into separate file Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 06/12] ath9k: convert to struct device Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 07/12] ath9k: introduce platform driver for AHB bus support Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-04 7:30 ` [ath9k-devel] " Christoph Hellwig
2009-01-04 7:30 ` Christoph Hellwig
2009-01-04 11:18 ` [ath9k-devel] " Gabor Juhos
2009-01-04 11:18 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 08/12] ath9k: get EEPROM contents from platform data on AHB bus Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-05 10:29 ` [ath9k-devel] " Sujith
2009-01-05 10:29 ` Sujith
2009-01-05 12:23 ` Gabor Juhos [this message]
2009-01-05 12:23 ` Gabor Juhos
2009-01-06 9:38 ` [ath9k-devel] " Sujith
2009-01-06 9:38 ` Sujith
2009-01-03 13:44 ` [ath9k-devel] [RFC 09/12] ath9k: enable support for AR9100 Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 10/12] ath9k: remove (u16) casts from rtc register access Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 11/12] ath9k: fix ar5416Addac_9100 values Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
2009-01-03 13:44 ` [ath9k-devel] [RFC 12/12] ath9k: fix null pointer dereference in ani monitor code Gabor Juhos
2009-01-03 13:44 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4961FBD1.4030103@openwrt.org \
--to=juhosg@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.