From: Robert Hancock <hancockr@shaw.ca>
To: linux-wireless@vger.kernel.org
Cc: orinoco-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: 2.6.28: warn_slowpath in orinoco receive path
Date: Mon, 05 Jan 2009 18:32:52 -0600 [thread overview]
Message-ID: <4962A6B4.7060309@shaw.ca> (raw)
In-Reply-To: <49628964.806@gmail.com>
Jiri Slaby wrote:
> On 01/05/2009 09:32 PM, Dave wrote:
>> --- a/drivers/net/wireless/orinoco/orinoco.c
>> +++ b/drivers/net/wireless/orinoco/orinoco.c
>> @@ -1616,9 +1616,15 @@ static void orinoco_rx_isr_tasklet(unsigned long
>> data)
>>
>> /* extract desc and skb from queue */
>> list_for_each_entry_safe(rx_data, temp, &priv->rx_list, list) {
>> + unsigned long flags;
>> +
>> desc = rx_data->desc;
>> skb = rx_data->skb;
>> +
>> + local_irq_save(flags);
>> list_del(&rx_data->list);
>> + local_irq_restore(flags);
>> +
>
> Hi,
>
> another processor still can see inconsistent state, spinlock should be taken.
> Or, am I missing something?
Think you're right, this should be spin_lock_irq or spin_lock_irqsave on
some lock. Otherwise the interrupt could still occur on some other CPU
and hit the race.
WARNING: multiple messages have this Message-ID (diff)
From: Robert Hancock <hancockr@shaw.ca>
To: linux-kernel@vger.kernel.org
Cc: linux-wireless@vger.kernel.org, orinoco-devel@lists.sourceforge.net
Cc: orinoco-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: 2.6.28: warn_slowpath in orinoco receive path
Date: Mon, 05 Jan 2009 18:32:52 -0600 [thread overview]
Message-ID: <4962A6B4.7060309@shaw.ca> (raw)
In-Reply-To: <49628964.806@gmail.com>
Jiri Slaby wrote:
> On 01/05/2009 09:32 PM, Dave wrote:
>> --- a/drivers/net/wireless/orinoco/orinoco.c
>> +++ b/drivers/net/wireless/orinoco/orinoco.c
>> @@ -1616,9 +1616,15 @@ static void orinoco_rx_isr_tasklet(unsigned long
>> data)
>>
>> /* extract desc and skb from queue */
>> list_for_each_entry_safe(rx_data, temp, &priv->rx_list, list) {
>> + unsigned long flags;
>> +
>> desc = rx_data->desc;
>> skb = rx_data->skb;
>> +
>> + local_irq_save(flags);
>> list_del(&rx_data->list);
>> + local_irq_restore(flags);
>> +
>
> Hi,
>
> another processor still can see inconsistent state, spinlock should be taken.
> Or, am I missing something?
Think you're right, this should be spin_lock_irq or spin_lock_irqsave on
some lock. Otherwise the interrupt could still occur on some other CPU
and hit the race.
next prev parent reply other threads:[~2009-01-06 1:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 17:05 2.6.28: warn_slowpath in orinoco receive path Andrey Borzenkov
2009-01-05 20:32 ` Dave
2009-01-05 22:27 ` Jiri Slaby
2009-01-06 0:32 ` Robert Hancock [this message]
2009-01-06 0:32 ` Robert Hancock
2009-01-06 9:51 ` Andrey Borzenkov
2009-01-06 20:02 ` Dave
2009-01-06 21:07 ` Andrey Borzenkov
2009-01-06 23:40 ` Dave
2009-01-07 2:42 ` [Orinoco-devel] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4962A6B4.7060309@shaw.ca \
--to=hancockr@shaw.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.