Re: ['meta-python][PATCH V2' 2/2] python3-uefi-firmware: add recipe for version 1.9

["tomzy" <tomasz.zyjewski@3mdeb.com>]

[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]

On Fri, Dec 2, 2022 at 10:56 AM, Michael Opdenacker wrote:

> 
> Hi Tomasz

Hi

> 
> Thanks for the patches!
> 
> On 12/1/22 09:24, tomzy wrote:
> 
>> Install uefi-firmware-parser tool
>> 
>> The UEFI firmware parseer is a simple module and set of scripts for
>> parsing, extracting, and recreating UEFI firmware volumes.
>> 
>> Signed-off-by: Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com>
>> ---
>> .../python/python3-uefi-firmware_1.9.bb | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644
>> meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb
> 
> However, if I apply your patch through "git am", the author of the
> commit will be:
> tomzy <tomasz.zyjewski@3mdeb.com>
> instead of
> Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com>
> 
> Because of this issue, the maintainer has to manually fix this field
> when accepting your patch. Worse, if he doesn't catch this, that's
> harder to fix afterwards.

I was not aware of this issue. I must have missed it in guidelines. Sorry for that!
> 
> 
> You should be able to fix this by running:
> git config --global sendemail.from "tomasz.zyjewski@3mdeb.com"
> 
> This should add a "From" field to the sent patch which "git am" should
> be able to match with your name.
> See
> https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email
> 
> 
> Could you try to send an update (don't hesitate to send a private one to
> me first)?

Thank you, I will try that. Should I use `michael.opdenacker@bootlin.com` ?

> 
> 
> Thanks in advance
> Michael.
> 
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

[-- Attachment #2: Type: text/html, Size: 2120 bytes --]