From: Arjan van de Ven <arjan@linux.intel.com>
To: Arjan van de Ven <arjan@linux.intel.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Grissiom <chaos.proton@gmail.com>,
linux-kernel@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock
Date: Thu, 08 Jan 2009 20:45:06 -0800 [thread overview]
Message-ID: <4966D652.4070105@linux.intel.com> (raw)
In-Reply-To: <20090109014054.GN9448@disturbed>
Dave Chinner wrote:
>
> So, given the potential impact of this change, what testing have
> you done in terms of:
>
> - performance impact
I tested this on my machines and it gave a real performance improvement (11 to 8 seconds for a full kernel tree unlink, and cutting out
latency for normal applications)
> - sync() safety
that was exactly the synchronization point that's discussed here.
> - removing a million files and queuing all of the
> deletes in the async queues....
the async code throttles at 32k outstanding.
Yes 32K is arbitrary, but if you delete a million files fast, all but the first few thousand are
synchronous.
WARNING: multiple messages have this Message-ID (diff)
From: Arjan van de Ven <arjan@linux.intel.com>
To: Arjan van de Ven <arjan@linux.intel.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Grissiom <chaos.proton@gmail.com>,
linux-kernel@vg
Subject: Re: [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock
Date: Thu, 08 Jan 2009 20:45:06 -0800 [thread overview]
Message-ID: <4966D652.4070105@linux.intel.com> (raw)
In-Reply-To: <20090109014054.GN9448@disturbed>
Dave Chinner wrote:
>
> So, given the potential impact of this change, what testing have
> you done in terms of:
>
> - performance impact
I tested this on my machines and it gave a real performance improvement (11 to 8 seconds for a full kernel tree unlink, and cutting out
latency for normal applications)
> - sync() safety
that was exactly the synchronization point that's discussed here.
> - removing a million files and queuing all of the
> deletes in the async queues....
the async code throttles at 32k outstanding.
Yes 32K is arbitrary, but if you delete a million files fast, all but the first few thousand are
synchronous.
next prev parent reply other threads:[~2009-01-09 4:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 8:07 "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Grissiom
2009-01-08 14:37 ` Dave Kleikamp
2009-01-08 15:21 ` Arjan van de Ven
2009-01-08 15:46 ` [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock Dave Kleikamp
2009-01-08 22:50 ` Dave Chinner
2009-01-08 22:51 ` Arjan van de Ven
2009-01-08 22:51 ` Arjan van de Ven
2009-01-09 0:32 ` Alan Cox
2009-01-09 0:38 ` Arjan van de Ven
2009-01-09 1:40 ` Dave Chinner
2009-01-09 1:40 ` Dave Chinner
2009-01-09 4:45 ` Arjan van de Ven [this message]
2009-01-09 4:45 ` Arjan van de Ven
2009-01-09 8:22 ` Dave Chinner
2009-01-09 15:09 ` Chris Mason
2009-01-12 2:31 ` Jamie Lokier
2009-01-12 3:54 ` Arjan van de Ven
2009-01-12 7:55 ` Dave Chinner
2009-01-12 7:48 ` Dave Chinner
2009-01-09 12:31 ` Evgeniy Polyakov
2009-01-09 5:18 ` "BUG: scheduling while atomic: pdflush/30/0x00000002" in latest git Grissiom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4966D652.4070105@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=chaos.proton@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.