All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jeff Garzik <jgarzik@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [fix] Too async libata breakage
Date: Fri, 09 Jan 2009 19:10:51 +0900	[thread overview]
Message-ID: <496722AB.7050805@kernel.org> (raw)
In-Reply-To: <49672166.4050606@gmail.com>

Hello,

Justin P. Mattock wrote:
> Linus Torvalds wrote:
>> On Thu, 8 Jan 2009, Justin P. Mattock wrote:
>>  
>>> O.K. attached is the results of
>>> dmesg after doing a git-pull
>>> (system didn't freeze, but there's
>>> a slew of warnings); i.g.
>>>     
>>
>> That's a different thing now - some very annoying warnings indeed.
>>
>> Tejun, I think it's yours. And I think it should be removed, or at the
>> very least changed into a WARN_ON_ONCE. Because spamming the console
>> with this is not a good idea:

Yeah, that's WARN_ON() on a pretty hot path.  I'll submit a patch to
convert it to WARN_ON_ONCE() but that's a condition which shouldn't
happen in the first place.  Strange.

Justin, can you please post the output of "lspci -nn" and full kernel
boot log?

Thanks.

-- 
tejun

  reply	other threads:[~2009-01-09 10:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08 20:02 Too async libata breakage Alexey Dobriyan
2009-01-08 20:17 ` Pekka Paalanen
2009-01-08 20:53   ` [fix] " Arjan van de Ven
2009-01-08 21:22     ` Justin P. Mattock
2009-01-08 22:20     ` Justin P. Mattock
2009-01-08 22:31       ` Arjan van de Ven
2009-01-08 23:26         ` Justin P. Mattock
2009-01-09  0:16         ` Justin P. Mattock
2009-01-09  0:23           ` Linus Torvalds
2009-01-09  0:33             ` Justin P. Mattock
2009-01-09 10:05             ` Justin P. Mattock
2009-01-09 10:10               ` Tejun Heo [this message]
2009-01-09 10:19               ` [PATCH] libata: use WARN_ON_ONCE on hot paths Tejun Heo
2009-01-09 11:31                 ` Zdenek Kabelac
2009-01-09 12:03                   ` Jeff Garzik
2009-01-09 12:07                     ` Alan Cox
2009-01-09 17:10                       ` Justin P. Mattock
2009-01-09 18:39                       ` Justin P. Mattock
2009-01-11 19:58                         ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496722AB.7050805@kernel.org \
    --to=tj@kernel.org \
    --cc=jgarzik@redhat.com \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.