From: Jeff Garzik <jeff@garzik.org>
To: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
"Justin P. Mattock" <justinmattock@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Garzik <jgarzik@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] libata: use WARN_ON_ONCE on hot paths
Date: Fri, 09 Jan 2009 07:03:14 -0500 [thread overview]
Message-ID: <49673D02.6000002@garzik.org> (raw)
In-Reply-To: <c4e36d110901090331r7c1cf06cy25c4a3a3579e47de@mail.gmail.com>
Zdenek Kabelac wrote:
> 2009/1/9 Tejun Heo <tj@kernel.org>:
>> Convert WARN_ON() on command issue/completion paths to WARN_ON_ONCE()
>> so that libata doesn't spam the machine even when one of those
>> conditions triggers repeatedly.
>>
>
>
> Hi
>
> I've not yet applied this patch - but now I'm getting these WARNS on my T61:
> (commit: 2150edc6c5cf00f7adb54538b9ea2a3e9cedca3f)
>
> Is this patch solving the problem or just hiding warnings ?
Hiding warnings. As Tejun noted in another email, this condition should
not be happening in the first place.
If I had to guess, I would say that Arjan's patches assume it is OK to
treat two ports on a single IDE controller as completely independent,
when that is not really the reality of the hardware.
Jeff
next prev parent reply other threads:[~2009-01-09 12:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 20:02 Too async libata breakage Alexey Dobriyan
2009-01-08 20:17 ` Pekka Paalanen
2009-01-08 20:53 ` [fix] " Arjan van de Ven
2009-01-08 21:22 ` Justin P. Mattock
2009-01-08 22:20 ` Justin P. Mattock
2009-01-08 22:31 ` Arjan van de Ven
2009-01-08 23:26 ` Justin P. Mattock
2009-01-09 0:16 ` Justin P. Mattock
2009-01-09 0:23 ` Linus Torvalds
2009-01-09 0:33 ` Justin P. Mattock
2009-01-09 10:05 ` Justin P. Mattock
2009-01-09 10:10 ` Tejun Heo
2009-01-09 10:19 ` [PATCH] libata: use WARN_ON_ONCE on hot paths Tejun Heo
2009-01-09 11:31 ` Zdenek Kabelac
2009-01-09 12:03 ` Jeff Garzik [this message]
2009-01-09 12:07 ` Alan Cox
2009-01-09 17:10 ` Justin P. Mattock
2009-01-09 18:39 ` Justin P. Mattock
2009-01-11 19:58 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49673D02.6000002@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=jgarzik@redhat.com \
--cc=justinmattock@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.