From: Casey Dahlin <cdahlin@redhat.com>
To: Scott James Remnant <scott@canonical.com>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Roland McGrath <roland@redhat.com>,
Davide Libenzi <davidel@xmailserver.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RESEND][RFC PATCH v2] waitfd
Date: Sat, 10 Jan 2009 17:08:53 -0500 [thread overview]
Message-ID: <49691C75.2000606@redhat.com> (raw)
In-Reply-To: <1231622419.11642.197.camel@quest>
Scott James Remnant wrote:
> On Sat, 2009-01-10 at 16:14 -0500, Casey Dahlin wrote:
>
>
>> From the perspective of waitfd, the only difference between WNOHANG and
>> O_NONBLOCK is which argument you put the flags in. The API should only
>> support one or the other, but internally they would imply the same thing.
>>
>>
> Well, you get O_NONBLOCK for free by having a file descriptor; and you
> can't turn off people trying to turn it on/off with fcntl() - so you may
> as well just use that, no? :-)
>
> Scott
>
Its purely an api question. We could easily take the WNOHANG flag and
just unset it when we get it and set O_NONBLOCK instead. We need
O_CLOEXEC anyway though, and the only reason to do it would be to get
rid of the O_ options and take only one type of flag (that and just a
little more waitid consistency).
--CJD
next prev parent reply other threads:[~2009-01-10 22:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 18:11 [RFC PATCH v2] waitfd Casey Dahlin
2009-01-06 18:27 ` Alan Cox
2009-01-06 18:31 ` Randy Dunlap
2009-01-06 18:45 ` Casey Dahlin
2009-01-06 18:50 ` Randy Dunlap
2009-01-06 18:48 ` Andi Kleen
2009-01-06 19:07 ` [RESEND][RFC " Casey Dahlin
2009-01-07 12:34 ` Ingo Molnar
2009-01-07 13:05 ` Casey Dahlin
2009-01-07 15:00 ` Ingo Molnar
2009-01-07 17:19 ` Oleg Nesterov
2009-01-07 17:24 ` Ingo Molnar
2009-01-07 17:52 ` Davide Libenzi
2009-01-07 20:38 ` Casey Dahlin
2009-01-10 14:47 ` Scott James Remnant
2009-01-10 21:14 ` Casey Dahlin
2009-01-10 21:20 ` Scott James Remnant
2009-01-10 22:08 ` Casey Dahlin [this message]
2009-01-10 22:31 ` Oleg Nesterov
2009-01-10 22:37 ` Casey Dahlin
2009-01-10 22:46 ` Oleg Nesterov
2009-01-07 20:53 ` Roland McGrath
2009-01-07 20:58 ` Ingo Molnar
2009-01-07 21:05 ` Davide Libenzi
2009-01-07 21:50 ` Ingo Molnar
2009-01-07 21:02 ` Ulrich Drepper
2009-01-08 14:32 ` Oleg Nesterov
2009-01-08 19:35 ` Roland McGrath
2009-01-08 20:36 ` Casey Dahlin
2009-01-08 21:39 ` Oleg Nesterov
2009-01-10 14:52 ` Scott James Remnant
2009-01-10 16:19 ` Oleg Nesterov
2009-01-10 17:09 ` Scott James Remnant
2009-01-10 18:21 ` Oleg Nesterov
2009-01-10 18:46 ` Scott James Remnant
2009-01-10 14:50 ` Scott James Remnant
2009-01-10 21:20 ` Casey Dahlin
2009-01-08 22:04 ` Michael Kerrisk
2009-01-10 14:09 ` Scott James Remnant
2009-01-10 14:45 ` Scott James Remnant
2009-01-10 15:57 ` Oleg Nesterov
2009-01-10 17:07 ` Scott James Remnant
2009-01-10 18:13 ` Oleg Nesterov
2009-01-10 20:13 ` Scott James Remnant
2009-01-10 22:24 ` Oleg Nesterov
2009-01-10 23:14 ` Davide Libenzi
2009-01-10 22:25 ` Casey Dahlin
2009-01-10 23:11 ` Davide Libenzi
2011-03-02 1:37 ` Denys Vlasenko
2011-03-02 13:55 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49691C75.2000606@redhat.com \
--to=cdahlin@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=randy.dunlap@oracle.com \
--cc=roland@redhat.com \
--cc=scott@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.