All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>,
	Dexuan Cui <dexuan.cui@intel.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86: add SSE-based copy_page()
Date: Tue, 13 Jan 2009 08:34:07 +0000	[thread overview]
Message-ID: <496C600F.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C591FDA7.20EC9%keir.fraser@eu.citrix.com>

>>> Keir Fraser <keir.fraser@eu.citrix.com> 13.01.09 09:13 >>>
>Seems like unless we dynamically choose the copy routine, we're better off
>without the SSE2 alternative. Shall I revert it then?

I'd vote for not reverting it - Xen itself doesn't use copy_page() much, and
whether a domain wants to use MMUEXT_COPY_PAGE could be decided by
it based on its own judgement.

Ultimately we should improve it as you say to dynamically select the copy
method, but then the question really is whether to base the selection on
static CPU information, best cold, or best warm cache performance.

Jan

  reply	other threads:[~2009-01-13  8:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12  9:37 [PATCH] x86: add SSE-based copy_page() Jan Beulich
2008-11-12 14:51 ` Dan Magenheimer
2008-11-12 15:01   ` Jan Beulich
2008-11-12 17:17     ` Dan Magenheimer
2008-11-13  8:37       ` Jan Beulich
2008-11-13 23:41         ` Dan Magenheimer
2008-11-14  3:08           ` Cui, Dexuan
2008-11-14 14:10             ` Dan Magenheimer
2008-11-14 14:16               ` Keir Fraser
2008-11-19 20:24                 ` Dan Magenheimer
2008-11-19 21:21                   ` Keir Fraser
2008-11-20  8:46                     ` Jan Beulich
2009-01-12 23:29                     ` Dan Magenheimer
2009-01-13  8:13                       ` Keir Fraser
2009-01-13  8:34                         ` Jan Beulich [this message]
2009-01-13  8:27                       ` Jan Beulich
  -- strict thread matches above, loose matches on Subject: below --
2009-01-13  8:31 Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496C600F.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=dexuan.cui@intel.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.