Re: [PATCH 1/1] ASoC: Fix compilation error with davinci-sffsdr module

[Troy Kisky <troy.kisky@boundarydevices.com>]

Mark Brown wrote:
> On Thu, Jan 15, 2009 at 02:54:54PM -0500, Hugo Villeneuve wrote:
>> Mark Brown <broonie@sirena.org.uk> wrote:
> 
>>>> The breakage I see when I run the aplay utility is this:
> 
>>>>   aplay: pcm_write:1394: write error: Input/output error
> 
>>>> davinci-git version is the latest as of january 14
>>>> (2.6.28-davinci1-06546-gcfb152b)
> 
>>> Hrm, OK.  That's not terribly informative - does the error get
>>> reported after about 10 seconds by any chance?  I suspect that DMA
>>> just isn't happening.
> 
>> Sorry about the non-verbosity :)
> 
> I actually meant the error message rather than your posting, sorry!
> 
>> Yes it happens almost exactly after 10 seconds. I?m not an expert with
>> audio nor DMA, but can you indicate me where I should be looking for
>> signs of trouble (which source files for example)?
> 
> sound/soc/davinci/davinci-pcm.c and the underlying DMA APIs it calls.  I
> wouldn't be surprised if either there had been some change in the DMA
> APIs that required an update in the driver or the DMA APIs haven't been
> fully merged.
> 
> Hopefully a comparison of the mainline and DaVinci trees will show
> something...
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

In davinci-sffsdr.c I see

	ret = snd_soc_dai_set_fmt(cpu_dai,
				  SND_SOC_DAIFMT_RIGHT_J |
				  SND_SOC_DAIFMT_CBM_CFS |
				  SND_SOC_DAIFMT_IB_NF);

When I changed the evm board flags passed, I didn't change this file. So, you'll need something like

	ret = snd_soc_dai_set_fmt(cpu_dai,
				  SND_SOC_DAIFMT_DSP_A |
				  SND_SOC_DAIFMT_CBM_CFS |
				  SND_SOC_DAIFMT_NB_NF);

But, you should be seeing error messages.

Troy