Re: [PATCH 1/1] ASoC: Fix compilation error with davinci-sffsdr module

[Troy Kisky <troy.kisky@boundarydevices.com>]

Hugo Villeneuve wrote:
> On Thu, 15 Jan 2009 15:10:01 -0700
> Troy Kisky <troy.kisky@boundarydevices.com> wrote:
> 
>>> Hopefully a comparison of the mainline and DaVinci trees will show
>>> something...
>> In davinci-sffsdr.c I see
>>
>> 	ret = snd_soc_dai_set_fmt(cpu_dai,
>> 				  SND_SOC_DAIFMT_RIGHT_J |
>> 				  SND_SOC_DAIFMT_CBM_CFS |
>> 				  SND_SOC_DAIFMT_IB_NF);
>>
>> When I changed the evm board flags passed, I didn't change this file.
>> So, you'll need something like
>>
>> 	ret = snd_soc_dai_set_fmt(cpu_dai,
>> 				  SND_SOC_DAIFMT_DSP_A |
>> 				  SND_SOC_DAIFMT_CBM_CFS |
>> 				  SND_SOC_DAIFMT_NB_NF);
> 
> I´m not using the same codec as on the EVM.

I know your not using the AIC33, but if your using davinci-i2s, then
the change will affect you.

> I´m using the PCM3008 and I
> need to use the right-justified mode and the SND_SOC_DAIFMT_IB_NF flag
> for it to work (it used to work a few weeks/months ago).

Davinci does not support a general right justified mode. But DSP_A may
be close enough. Especially if it worked before.

>  
>> But, you should be seeing error messages.
> 
> Did someone test the latest git tree and audio on a DM644x EVM to see if
> it still works?

I don't have an evm, but our custom board works fine.


Troy