All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Molton <ian@mnementh.co.uk>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Takashi Iwai <tiwai@suse.de>,
	ALSA development <alsa-devel@alsa-project.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [Pull request] Support for wm9705 codec and two machines that use it.
Date: Thu, 15 Jan 2009 23:58:36 +0000	[thread overview]
Message-ID: <496FCDAC.70900@mnementh.co.uk> (raw)
In-Reply-To: <20090115222228.GA8806@sirena.org.uk>

Mark Brown wrote:
> On Thu, Jan 15, 2009 at 10:16:10PM +0000, Ian Molton wrote:
>> Mark Brown wrote:
> 
>>>> +	soc_ac97_ops.reset(codec->ac97);
> 
>>> This should check the return value, resets can and do fail.
> 
>> This call returns void. So no.
> 
> Oh, sorry - thinko.  You should read back the ID register and verify the
> value.

Implemented, tested, checkpatch passed.

Pushed out and available at:

git://git.mnementh.co.uk/linux-2.6-im.git asoc

gitweb at:

http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=shortlog;h=refs/heads/asoc

Thanks for the review,

-Ian

  reply	other threads:[~2009-01-15 23:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15  1:13 [Pull request] Support for wm9705 codec and two machines that use it Ian Molton
2009-01-15  1:16 ` Ian Molton
2009-01-15  7:06 ` Takashi Iwai
2009-01-15 10:06   ` Ian Molton
2009-01-15 10:10     ` Russell King - ARM Linux
2009-01-15 10:47       ` Ian Molton
2009-01-15 17:20     ` Mark Brown
2009-01-15 22:16       ` Ian Molton
2009-01-15 22:22         ` Mark Brown
2009-01-15 23:58           ` Ian Molton [this message]
2009-01-16 11:21             ` Mark Brown
2009-01-16 11:03     ` Takashi Iwai
2009-01-16 11:34       ` Ian Molton
2009-01-16 11:54         ` Mark Brown
2009-01-16 13:39           ` Ian Molton
2009-01-16 14:31             ` Mark Brown
2009-01-16 15:00               ` Ian Molton
2009-01-16 16:00                 ` Mark Brown
2009-01-16 15:46               ` Ian Molton
2009-01-16 16:16                 ` Mark Brown
2009-01-17 17:58                 ` Mark Brown
2009-01-17 18:47                   ` Ian Molton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496FCDAC.70900@mnementh.co.uk \
    --to=ian@mnementh.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    --cc=linux@arm.linux.org.uk \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.