From: Ian Molton <ian@mnementh.co.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [Pull request] Support for wm9705 codec and two machines that use it.
Date: Fri, 16 Jan 2009 11:34:41 +0000 [thread overview]
Message-ID: <497070D1.50301@mnementh.co.uk> (raw)
In-Reply-To: <s5hk58v4inq.wl%tiwai@suse.de>
Takashi Iwai wrote:
> At Thu, 15 Jan 2009 10:06:53 +0000,
> Ian Molton wrote:
> Shouldn't be this "reg >= ARRAY_SIZE(wm9705_reg)" ?
Looks that way. Will fix.
I've spotted the same error in a couple of other drivers too.
It looks like register caching is a very common thing, would you be
interested in a patch that consolidates the cache handling in soc-core,
rather than having multiple possibly broken implementations around?
Also, I could be wrong, but wm8980 caching looks completely broken
(array is type u16 but there is no register shift applied, AFAICT)
fixed in wm9705 for now anyway.
> Ditto, should be "reg < ARRAY_SIZE(wm9705_reg)".
Fixed.
> You can use kmemdup() here.
Changed.
TTFN,
-Ian
next prev parent reply other threads:[~2009-01-16 11:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 1:13 [Pull request] Support for wm9705 codec and two machines that use it Ian Molton
2009-01-15 1:16 ` Ian Molton
2009-01-15 7:06 ` Takashi Iwai
2009-01-15 10:06 ` Ian Molton
2009-01-15 10:10 ` Russell King - ARM Linux
2009-01-15 10:47 ` Ian Molton
2009-01-15 17:20 ` Mark Brown
2009-01-15 22:16 ` Ian Molton
2009-01-15 22:22 ` Mark Brown
2009-01-15 23:58 ` Ian Molton
2009-01-16 11:21 ` Mark Brown
2009-01-16 11:03 ` Takashi Iwai
2009-01-16 11:34 ` Ian Molton [this message]
2009-01-16 11:54 ` Mark Brown
2009-01-16 13:39 ` Ian Molton
2009-01-16 14:31 ` Mark Brown
2009-01-16 15:00 ` Ian Molton
2009-01-16 16:00 ` Mark Brown
2009-01-16 15:46 ` Ian Molton
2009-01-16 16:16 ` Mark Brown
2009-01-17 17:58 ` Mark Brown
2009-01-17 18:47 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497070D1.50301@mnementh.co.uk \
--to=ian@mnementh.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=linux@arm.linux.org.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.