* x.25: x25_rx_call_request() skb->len >= 0 is always true
@ 2009-01-18 21:46 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-01-18 21:46 UTC (permalink / raw)
To: eis; +Cc: linux-x25
since skb->len is unsigned this is always true.
vi net/x25/af_x25.c +954
if (skb->len >= 0) {
skb_copy_from_linear_data(skb, makex25->calluserdata.cuddata, skb->len);
makex25->calluserdata.cudlength = skb->len;
}
shouldn't we instead do something like
if (skb->len < LEN_MAX)
and what should LEN_MAX be?
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-18 21:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-18 21:46 x.25: x25_rx_call_request() skb->len >= 0 is always true Roel Kluin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.