All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel] [6344]	graphical_console_init change	(Stefano	Stabellini)
Date: Mon, 19 Jan 2009 15:31:03 +0000	[thread overview]
Message-ID: <49749CB7.1020508@eu.citrix.com> (raw)
In-Reply-To: <49749B91.6080200@juno.dti.ne.jp>

Shin-ichiro KAWASAKI wrote:

> Stefano Stabellini wrote:
>> Shin-ichiro KAWASAKI wrote:
>>
>>> I'm sending the patch which solves the problem above.
>>> Could anyone evaluate it?
>>>
>>
>>
>>
>> Thanks for spotting the bug and your work on a patch!
>>
>> However I think the following fix is cleaner: we do not need a
>> dumb_display_init that creates an empty DisplayChangeListener any more.
>> We do need a dumb_display_init that allocates a zeroed DisplayState
>> structure if none else does it.
>>
>> Please let me know if it also fixes you problem.
> 
> It solves my problem finely.  Thank you!
> 
> Tested-by: Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>
> 

Thanks for testing it.
Anthony, before committing this patch, check out the other equivalent
patch I sent as I reply to 'add a -vga none cli option'.

  reply	other threads:[~2009-01-19 15:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-16 19:04 [Qemu-devel] [6344] graphical_console_init change (Stefano Stabellini) Anthony Liguori
2009-01-18 12:54 ` Shin-ichiro KAWASAKI
2009-01-18 14:37   ` Aurelien Jarno
2009-01-18 14:48   ` [PATCH] Adds null check for DisplayStatus (wasRe: " Shin-ichiro KAWASAKI
2009-01-19 11:39     ` Stefano Stabellini
2009-01-19 15:26       ` Shin-ichiro KAWASAKI
2009-01-19 15:31         ` Stefano Stabellini [this message]
2009-01-19 16:08           ` Anthony Liguori
2009-01-19 16:19             ` Stefano Stabellini
2009-01-19 19:07               ` Anthony Liguori
2009-01-20 10:53                 ` [Qemu-devel] [PATCH] Adds null check for DisplayStatus Stefano Stabellini
2009-01-20 15:56                   ` Gerd Hoffmann
2009-01-20 16:36                     ` Stefano Stabellini
2009-01-21 11:06                   ` [Qemu-devel] " Stefano Stabellini
2009-01-21 18:59                   ` [Qemu-devel] " Anthony Liguori
2009-01-19 16:34       ` [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel] [6344] graphical_console_init change (Stefano Stabellini) Anthony Liguori
2009-02-09 11:38 ` Riku Voipio
2009-02-09 11:52   ` Stefano Stabellini
2009-02-09 17:00   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49749CB7.1020508@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.