Re: [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel] [6344] graphical_console_init change (Stefano Stabellini)

[Anthony Liguori <anthony@codemonkey.ws>]

Stefano Stabellini wrote:
> Anthony Liguori wrote:
>
>   
>> Stefano Stabellini wrote:
>>     
>>> Thanks for testing it.
>>> Anthony, before committing this patch, check out the other equivalent
>>> patch I sent as I reply to 'add a -vga none cli option'.
>>>   
>>>       
>> Hi Stefan,
>>
>> Are you working on a fix for the SEGV when not using -nographic?  If I run:
>>
>> qemu -hda image.foo -snapshot -vga none
>>
>> I get a segv b/c SDL_SetVideoMode() uses ds_get_width/height and
>> ds->surface == NULL.
>>
>>     
>
>
>
> Yes, the complete fix is the following, it also solves the other bug that
> arises when you set -vga none but you do not specify -nographic:
>
>   
I already applied your first.  Can you send a diff against SVN along 
with a Signed-off-by line?

Thanks,

Anthony Liguori
>
>