From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Joe Perches <joe@perches.com>
Cc: Sridhar Samudrala <sri@us.ibm.com>,
Networking Team <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp/ipv6.c: use ipv6_addr_copy
Date: Thu, 22 Jan 2009 21:18:43 +0000 [thread overview]
Message-ID: <4978E2B3.3010109@hp.com> (raw)
In-Reply-To: <1232658506.15489.63.camel@localhost>
Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index ceaa4aa..7862275 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -97,8 +97,7 @@ static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
> if (addr) {
> addr->a.v6.sin6_family = AF_INET6;
> addr->a.v6.sin6_port = 0;
> - memcpy(&addr->a.v6.sin6_addr, &ifa->addr,
> - sizeof(struct in6_addr));
> + ipv6_addr_copy(&addr->a.v6.sin6_addr, &ifa->addr);
> addr->a.v6.sin6_scope_id = ifa->idev->dev->ifindex;
> addr->valid = 1;
> spin_lock_bh(&sctp_local_addr_lock);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
ACK. Simple enough of a cleanup.
-vlad
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Joe Perches <joe@perches.com>
Cc: Sridhar Samudrala <sri@us.ibm.com>,
Networking Team <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp/ipv6.c: use ipv6_addr_copy
Date: Thu, 22 Jan 2009 16:18:43 -0500 [thread overview]
Message-ID: <4978E2B3.3010109@hp.com> (raw)
In-Reply-To: <1232658506.15489.63.camel@localhost>
Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index ceaa4aa..7862275 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -97,8 +97,7 @@ static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
> if (addr) {
> addr->a.v6.sin6_family = AF_INET6;
> addr->a.v6.sin6_port = 0;
> - memcpy(&addr->a.v6.sin6_addr, &ifa->addr,
> - sizeof(struct in6_addr));
> + ipv6_addr_copy(&addr->a.v6.sin6_addr, &ifa->addr);
> addr->a.v6.sin6_scope_id = ifa->idev->dev->ifindex;
> addr->valid = 1;
> spin_lock_bh(&sctp_local_addr_lock);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
ACK. Simple enough of a cleanup.
-vlad
next prev parent reply other threads:[~2009-01-22 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 21:08 [PATCH] sctp/ipv6.c: use ipv6_addr_copy Joe Perches
2009-01-22 21:08 ` Joe Perches
2009-01-22 21:18 ` Vlad Yasevich [this message]
2009-01-22 21:18 ` Vlad Yasevich
2009-01-22 21:50 ` David Miller
2009-01-22 21:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4978E2B3.3010109@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=joe@perches.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.