Re: [PATCH v3 05/11] ARM: dts: add exynos4 clock controller nodes

[Tomasz Figa <tomasz.figa@gmail.com>]

On Thursday 15 of November 2012 03:37:27 Thomas Abraham wrote:
> Add clock controller nodes for Exynos4210 and Exynos4x12 SoC's.
> 
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4210.dtsi |    6 ++++++
>  arch/arm/boot/dts/exynos4x12.dtsi |    6 ++++++
>  2 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi
> b/arch/arm/boot/dts/exynos4210.dtsi index d6fc306..f7daa09 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -50,6 +50,12 @@
>  		samsung,mct-nr-local-irqs = <4>;
>  	};
> 
> +	clock: clock-controller@0x10030000 {
> +		compatible = "samsung,exynos4210-clock";
> +		reg = <0x10030000 0x20000>;
> +		#clock-cells = <1>;
> +	};
> +
>  	pinctrl_0: pinctrl@11400000 {
>  		compatible = "samsung,pinctrl-exynos4210";
>  		reg = <0x11400000 0x1000>;
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> b/arch/arm/boot/dts/exynos4x12.dtsi index 7cbbd19..bcfdaac 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -35,6 +35,12 @@
>  			     <0 16 0>, <0 17 0>, <0 18 0>, <0 19 0>;
>  	};
> 
> +	clock: clock-controller@0x10030000 {
> +		compatible = "samsung,exynos4412-clock";

nitpick: I forgot to mention about it in my comments for patch 3, but 
wouldn't it be better to call it "samsung,exynos4x12-clock"?

> +		reg = <0x10030000 0x20000>;
> +		#clock-cells = <1>;
> +	};
> +
>  	pinctrl_0: pinctrl@11400000 {
>  		compatible = "samsung,pinctrl-exynos4x12";
>  		reg = <0x11400000 0x1000>;

Otherwise looks fine.

Best regards,
Tomasz Figa