* [PATCH] atiixp: change parameter to macro define
@ 2009-01-23 2:48 Matthew Ranostay
2009-01-23 7:48 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Ranostay @ 2009-01-23 2:48 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai
Change 0x15bd parameter to PCI_VENDOR_ID_DFI define.
Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
---
diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c
index 9ce8548..6baa6c4 100644
--- a/sound/pci/atiixp.c
+++ b/sound/pci/atiixp.c
@@ -297,7 +297,7 @@ static struct pci_device_id snd_atiixp_ids[] = {
MODULE_DEVICE_TABLE(pci, snd_atiixp_ids);
static struct snd_pci_quirk atiixp_quirks[] __devinitdata = {
- SND_PCI_QUIRK(0x15bd, 0x3100, "DFI RS482", 0),
+ SND_PCI_QUIRK(PCI_VENDOR_ID_DFI, 0x3100, "DFI RS482", 0),
{ } /* terminator */
};
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] atiixp: change parameter to macro define
2009-01-23 2:48 [PATCH] atiixp: change parameter to macro define Matthew Ranostay
@ 2009-01-23 7:48 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-01-23 7:48 UTC (permalink / raw)
To: Matthew Ranostay; +Cc: alsa-devel
At Thu, 22 Jan 2009 21:48:51 -0500,
Matthew Ranostay wrote:
>
> Change 0x15bd parameter to PCI_VENDOR_ID_DFI define.
>
> Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
Well, I won't apply this. PCI_VENDOR_ID_* isn't always good especially
for some table. You'll often need to check a certain PCI (SS)ID, and
the literal makes the comparison hard.
OTOH, with PCI_VENDOR_ID_*, a number-typo can be avoided better, so
it's good as a first place.
Takashi
>
> diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c
> index 9ce8548..6baa6c4 100644
> --- a/sound/pci/atiixp.c
> +++ b/sound/pci/atiixp.c
> @@ -297,7 +297,7 @@ static struct pci_device_id snd_atiixp_ids[] = {
> MODULE_DEVICE_TABLE(pci, snd_atiixp_ids);
>
> static struct snd_pci_quirk atiixp_quirks[] __devinitdata = {
> - SND_PCI_QUIRK(0x15bd, 0x3100, "DFI RS482", 0),
> + SND_PCI_QUIRK(PCI_VENDOR_ID_DFI, 0x3100, "DFI RS482", 0),
> { } /* terminator */
> };
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-23 7:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-23 2:48 [PATCH] atiixp: change parameter to macro define Matthew Ranostay
2009-01-23 7:48 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.