* [PATCH] smackfs load append mode fix
@ 2009-01-28 3:56 Casey Schaufler
0 siblings, 0 replies; only message in thread
From: Casey Schaufler @ 2009-01-28 3:56 UTC (permalink / raw)
To: LKLM, LSM, jmorris; +Cc: Ahmed S. Darwish, akpm, torvalds
From: Casey Schaufler <casey@schaufler-ca.com>
Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
---
security/smack/smackfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6/security/smack/smackfs.c linux-0112/security/smack/smackfs.c
--- linux-2.6/security/smack/smackfs.c 2009-01-09 21:43:42.000000000 -0800
+++ linux-0112/security/smack/smackfs.c 2009-01-19 11:05:09.000000000 -0800
@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct fil
break;
case 'a':
case 'A':
- rule.smk_access |= MAY_READ;
+ rule.smk_access |= MAY_APPEND;
break;
default:
goto out;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-28 4:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 3:56 [PATCH] smackfs load append mode fix Casey Schaufler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.