All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr-fVOoFLC7IWo@public.gmane.org>
To: Greg KH
	<public-greg-U8xfFu+wG4EAvxtiuMwx3w-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org>
Cc: public-mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org,
	public-linux-man-u79uwXL29TY76Z2rM5mHXA-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org,
	public-linux-kernel-u79uwXL29TY76Z2rM5mHXA-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org
Subject: Re: open(2) says O_DIRECT works on 512 byte boundries?
Date: Wed, 28 Jan 2009 18:41:49 -0600	[thread overview]
Message-ID: <4980FB4D.9090009@shaw.ca> (raw)
In-Reply-To: <20090128213322.GA15789-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>



Greg KH wrote:
> In looking at open(2), it says that O_DIRECT works on 512 byte boundries
> with the 2.6 kernel release:
> 	Under Linux 2.4, transfer sizes, and the alignment of the user
> 	buffer and  the file offset must all be multiples of the logical
> 	block size of the file system.  Under Linux 2.6, alignment  to
> 	512-byte  boundaries suffices.
> 
> However if you try to access an O_DIRECT opened file with a buffer that
> is PAGE_SIZE aligned + 512 bytes, it fails in a bad way (wrong data is
> read.)
> 
> Is this just a mistake in the documentation?  Or am I reading it
> incorrectly?
> 
> I have a test program that shows this if anyone wants it.

Well, it sounds like a bug to me.. even if it's not supported, if you do 
such an access, surely the kernel should detect that and return EINVAL 
or something rather than reading corrupted data..

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Robert Hancock <hancockr@shaw.ca>
To: linux-kernel@vger.kernel.org
Cc: linux-man@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: open(2) says O_DIRECT works on 512 byte boundries?
Date: Wed, 28 Jan 2009 18:41:49 -0600	[thread overview]
Message-ID: <4980FB4D.9090009@shaw.ca> (raw)
In-Reply-To: <20090128213322.GA15789@kroah.com>

Greg KH wrote:
> In looking at open(2), it says that O_DIRECT works on 512 byte boundries
> with the 2.6 kernel release:
> 	Under Linux 2.4, transfer sizes, and the alignment of the user
> 	buffer and  the file offset must all be multiples of the logical
> 	block size of the file system.  Under Linux 2.6, alignment  to
> 	512-byte  boundaries suffices.
> 
> However if you try to access an O_DIRECT opened file with a buffer that
> is PAGE_SIZE aligned + 512 bytes, it fails in a bad way (wrong data is
> read.)
> 
> Is this just a mistake in the documentation?  Or am I reading it
> incorrectly?
> 
> I have a test program that shows this if anyone wants it.

Well, it sounds like a bug to me.. even if it's not supported, if you do 
such an access, surely the kernel should detect that and return EINVAL 
or something rather than reading corrupted data..


  parent reply	other threads:[~2009-01-29  0:41 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 21:33 open(2) says O_DIRECT works on 512 byte boundries? Greg KH
2009-01-28 21:33 ` Greg KH
     [not found] ` <20090128213322.GA15789-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-01-29  0:41   ` Robert Hancock [this message]
2009-01-29  0:41     ` Robert Hancock
     [not found]     ` <4980FB4D.9090009-fVOoFLC7IWo@public.gmane.org>
2009-01-29  1:17       ` Greg KH
     [not found]         ` <20090129011758.GA26534-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-01-29  2:59           ` Michael Kerrisk
2009-01-29  2:59             ` Michael Kerrisk
2009-01-29  3:13             ` Greg KH
     [not found]               ` <20090129031349.GA23722-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-01-29 15:40                 ` Jeff Moyer
2009-01-29 15:40                   ` Jeff Moyer
     [not found]                   ` <x49iqnyi0ih.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2009-01-30  6:16                     ` Greg KH
2009-01-30  6:16                       ` Greg KH
2009-01-29  5:13   ` KAMEZAWA Hiroyuki
2009-01-29  5:13     ` KAMEZAWA Hiroyuki
     [not found]     ` <20090129141338.34e44a1f.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-01-29  7:10       ` KOSAKI Motohiro
2009-01-29  7:10         ` KOSAKI Motohiro
     [not found]         ` <20090129160826.701E.KOSAKI.MOTOHIRO-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-01-30  6:17           ` Greg KH
2009-01-30  6:17             ` Greg KH
     [not found]             ` <20090130061714.GC31209-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-02-02 22:08               ` Andrea Arcangeli
2009-02-02 22:08                 ` Andrea Arcangeli
2009-02-03  1:29                 ` KAMEZAWA Hiroyuki
     [not found]                   ` <20090203102920.684e7b67.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-02-03  2:31                     ` Andrea Arcangeli
2009-02-03  2:31                       ` Andrea Arcangeli
     [not found]                       ` <20090203023147.GZ20323-ulAA2RpUuRJvbPj5LQlJ3g@public.gmane.org>
2009-02-03  2:55                         ` KAMEZAWA Hiroyuki
2009-02-03  2:55                           ` KAMEZAWA Hiroyuki
     [not found]                           ` <20090203115540.86a01273.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-02-03  3:42                             ` KAMEZAWA Hiroyuki
2009-02-03  3:42                               ` KAMEZAWA Hiroyuki
2009-02-06 17:55                             ` Andrea Arcangeli
2009-02-06 17:55                               ` Andrea Arcangeli
     [not found]                 ` <20090202220856.GY20323-ulAA2RpUuRJvbPj5LQlJ3g@public.gmane.org>
2009-02-03  3:50                   ` Greg KH
2009-02-03  3:50                     ` Greg KH
     [not found]                     ` <20090203035012.GC1867-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-02-03 15:01                       ` Andrea Arcangeli
2009-02-03 15:01                         ` Andrea Arcangeli
2009-02-03  4:13                   ` KAMEZAWA Hiroyuki
2009-02-03  4:13                     ` KAMEZAWA Hiroyuki
2009-02-03  4:38                   ` KAMEZAWA Hiroyuki
2009-02-03  4:38                     ` KAMEZAWA Hiroyuki
     [not found]                     ` <20090203133811.47324d80.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-02-03 15:08                       ` Andrea Arcangeli
2009-02-03 15:08                         ` Andrea Arcangeli
2009-02-04 23:41                   ` Greg KH
2009-02-04 23:41                     ` Greg KH
     [not found]                     ` <20090204234153.GA32244-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-02-06 17:54                       ` Andrea Arcangeli
2009-02-06 17:54                         ` Andrea Arcangeli
     [not found]                         ` <20090206175414.GQ14011-ulAA2RpUuRJvbPj5LQlJ3g@public.gmane.org>
2009-02-06 18:38                           ` Andrea Arcangeli
2009-02-06 18:38                             ` Andrea Arcangeli
2009-02-07 13:32                           ` Izik Eidus
2009-02-07 13:32                             ` Izik Eidus
     [not found]                             ` <498D8D53.6030007-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-02-07 15:33                               ` Andrea Arcangeli
2009-02-07 15:33                                 ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4980FB4D.9090009@shaw.ca \
    --to=hancockr-fvooflc7iwo@public.gmane.org \
    --cc=public-greg-U8xfFu+wG4EAvxtiuMwx3w-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org \
    --cc=public-linux-kernel-u79uwXL29TY76Z2rM5mHXA-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org \
    --cc=public-linux-man-u79uwXL29TY76Z2rM5mHXA-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org \
    --cc=public-mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w-z5DuStaUktnZ+VzJOa5vwg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.